GetFullChat + GetAllChats + MakeAuthBotAsync + Other methods by solarin · Pull Request #926 · sochix/TLSharp

solarin · 2020-04-03T13:58:55Z

GetFullChat to get the info of a chat
GetAllChats to get all available user's chats
MakeAuthBotAsync to authenticate a bot instead of a user

added the csproj

+ GetAllChats to get all available user's chats + MakeAuthBotAsync to authenticate a bot instead of a user

knocte · 2020-04-03T14:16:37Z

You need to remove the DataCenterIPVersion stuff from here, otherwise the PRs are not separate (if I merge the other one, there will be conflicts here).

There were less places with underscores in field names than places without them, so we now are consistent with the most abundant occurrence.

solarin · 2020-04-03T16:32:19Z

You need to remove the DataCenterIPVersion stuff from here, otherwise the PRs are not separate (if I merge the other one, there will be conflicts here).

ok i think it's ok now

knocte · 2020-04-05T12:10:47Z

@aarani can you review this PR?

! Added token to the parameters of async methods ! Typos and comments

aarani · 2020-04-05T15:51:46Z

TLSharp.Core/TelegramClient.cs

+using TLSharp.Core.Types;
 using TLSharp.Core.Utils;
 using TLAuthorization = TeleSharp.TL.Auth.TLAuthorization;
+using TLRequestUpdateUsername = TeleSharp.TL.Account.TLRequestUpdateUsername;


what's the reason behind this? just use it directly inside the code. there is hundreds of request used in this file. no need to add alias for just one use

actually TLRequestUpdateUsername is ambigous with as it's already present in TL.Channels. i can double check and report exactly where.

'TLRequestUpdateUsername' is an ambiguous reference between 'TeleSharp.TL.Account.TLRequestUpdateUsername' and 'TeleSharp.TL.Channels.TLRequestUpdateUsername'

'TLAuthorization' is an ambiguous reference between 'TeleSharp.TL.Auth.TLAuthorization' and 'TeleSharp.TL.TLAuthorization' TLSharp.Core

that's fair enough

TLSharp.Core/TelegramClient.cs

aarani · 2020-04-05T15:59:08Z

TLSharp.Core/TelegramClient.cs

+        /// <param name="accessHash">The access hash of the channel to invite the users to</param>
+        /// <param name="users"></param>
+        /// <returns></returns>
+        public async Task<TLUpdates> InviteToChannel(int channelId, long accessHash, int[] users, CancellationToken token = default(CancellationToken))


maybe use TLChannel or TLInputChannel as parameter here?

I create an overload as for the other methods, ok?

This function is not working, always return UserId_Invalid exception
You have to assign both UserId and Hash to TLInputUser.

@jamesjsc do you mind porting this PR to TgSharp?

@knocte What is the different between TLSharp and TgSharp?

TL Layer update, Tg is the future, TL will just receive bug fixes, no new features.

aarani · 2020-04-05T16:00:48Z

TLSharp.Core/TelegramClient.cs

+                case ParticipantTypes.Contacts:
+                case ParticipantTypes.Search:
+                default:
+                    throw new NotImplementedException($"{partType} not implemented yet");


If it's not gonna be implemented please remove them from your enum as the only purpose of enum is for this filter

it's gonna be implemented as soon as the new Classes are added to the TL framework

should i drop them anyways or leave them?

are they present in the new layers?

yes, see here: https://core.telegram.org/type/ChannelParticipantsFilter

I vote, then, for only merging this PR after we have updated the layer

TLSharp.Core/TelegramClient.cs

aarani · 2020-04-05T16:11:38Z

TLSharp.Core/Types/ParticipantTypes.cs

@@ -0,0 +1,16 @@
+namespace TLSharp.Core.Types
+{
+    public enum ParticipantTypes


Change this to something like ParticipantTypesFilter too maybe?

ParticipantTypeFilters

ok?

! filter wasn't actually used ! renamed the ParticipantTypes -> ParticipantFilterTypes

TLSharp.Core/TelegramClient.cs

knocte · 2020-04-06T06:44:56Z

TLSharp.Core/TelegramClient.cs

+                Location = location,
+                Limit = filePartSize,
+                Offset = offset
+            }, token)


you formatted the whole file again by mistake, can you create a separate PR just to format the file please?

see the next commit

This reverts commit 45be5f5.

+ eol

solarin · 2020-04-06T07:11:33Z

TLSharp.Core/TelegramClient.cs

+                var fchat = await SendRequestAsync<TLChannelParticipants>(req, token).ConfigureAwait(false);
+                total = fchat.Count;
+                found += fchat.Participants.Count;
+                results.Add(fchat);


i must remove this results. it is useless.

knocte · 2020-04-06T07:34:35Z

TLSharp.Core/TelegramClient.cs

+        {
+            var ichats = new TeleSharp.TL.TLVector<int>(); // we can't pass a null argument to the TLRequestGetChats
+            if (exceptdIds != null)
+                Array.ForEach(exceptdIds, x => ichats.Add(x));


I'm not a fan of Array.ForEach because it hardcodes "Array"; isn't there an IEnumerable-esque way of doing this?

// there is a handy constructor
var ichats = exceptdIds!=null ? new TeleSharp.TL.TLVector(exceptdIds) : new TeleSharp.TL.TLVector();

// if (exceptdIds != null)
// Array.ForEach(exceptdIds, x => ichats.Add(x));

solarin · 2020-04-06T07:41:29Z

@knocte as for the Array.ForEach, the only replacement i am aware of is to do a classic for(int i...). i wouldn't use any other list in this case as they would introduce a worse overhead than the Array.ForEach.

knocte · 2020-04-06T08:03:26Z

as for the Array.ForEach, the only replacement i am aware of is to do a classic for(int i...). i wouldn't use any other list in this case as they would introduce a worse overhead than the Array.ForEach.

Let's use a normal foreach then. More reasoning here: https://docs.microsoft.com/en-gb/archive/blogs/ericlippert/foreach-vs-foreach

solarin added 5 commits April 3, 2020 17:05

Added an IPv4/IPv6 toggle to TelegramClient constructor

80d16fe

tabs-> 4 spaces

e067688

added the csproj

+ GetFullChat to get the info of a chat

92ca5a9

+ GetAllChats to get all available user's chats + MakeAuthBotAsync to authenticate a bot instead of a user

fixed typos and spaces

406a73b

+ GetFullChat to get the info of a chat

54781b2

+ GetAllChats to get all available user's chats + MakeAuthBotAsync to authenticate a bot instead of a user

knocte and others added 2 commits April 3, 2020 20:31

style: more consistent naming removing underscores

2d4aa3e

There were less places with underscores in field names than places without them, so we now are consistent with the most abundant occurrence.

removed the previously added changed not pertinent to this PR

00fb3ae

solarin added 3 commits April 5, 2020 15:42

65ff8cc

added methods to get the participants of a group/channel

3721e8c

removed unnecessary file

c28a41c

+ InviteToChannel

7dedf2a

! Added token to the parameters of async methods ! Typos and comments

solarin changed the title ~~GetFullChat + GetAllChats + MakeAuthBotAsync~~ GetFullChat + GetAllChats + MakeAuthBotAsync + Other methods Apr 5, 2020

aarani suggested changes Apr 5, 2020

View reviewed changes

aarani reviewed Apr 5, 2020

View reviewed changes

+ overload for method InviteToChannel

45be5f5

! filter wasn't actually used ! renamed the ParticipantTypes -> ParticipantFilterTypes

knocte reviewed Apr 6, 2020

View reviewed changes

TLSharp.Core/TelegramClient.cs Show resolved Hide resolved

knocte reviewed Apr 6, 2020

View reviewed changes

solarin added 2 commits April 6, 2020 10:45

Revert "+ overload for method InviteToChannel"

9623f9d

This reverts commit 45be5f5.

! fixed conflicts

ce93c76

+ eol

solarin commented Apr 6, 2020

View reviewed changes

remove unnecessary list usage

27d680f

knocte reviewed Apr 6, 2020

View reviewed changes

solarin mentioned this pull request Apr 9, 2020

TLSharp Get All Members In Group #934

Open

Conversation

solarin commented Apr 3, 2020

Uh oh!

knocte commented Apr 3, 2020

Uh oh!

solarin commented Apr 3, 2020

Uh oh!

knocte commented Apr 5, 2020

Uh oh!

aarani Apr 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solarin Apr 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barrywimlett Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solarin commented Apr 6, 2020

Uh oh!

knocte commented Apr 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

aarani Apr 5, 2020 •

edited

Loading

solarin Apr 5, 2020 •

edited

Loading

barrywimlett Dec 3, 2020 •

edited

Loading