This repository was archived by the owner on Dec 5, 2021. It is now read-only.
Remove Duplicate Code#747
Open
aarani wants to merge 1 commit intosochix:masterfrom
aarani:remove-duplicate-writing
Open
Remove Duplicate Code#747aarani wants to merge 1 commit intosochix:masterfrom aarani:remove-duplicate-writing
aarani wants to merge 1 commit intosochix:masterfrom
aarani:remove-duplicate-writing
Conversation
Serializer now write constructor 2 times and it makes API request fail
Contributor
Author
|
P.S : it only happen when you use "byte[] Serialize()" |
Collaborator
You mean it fails because of your commit that changed from GetBuffer to ToArray? |
Contributor
Author
|
@knocte no It’s not related to other PR if You check SerializeBody function it write constructor too so we write it two times now and API return error in that case |
Collaborator
Copy+paste error please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializer now write constructor 2 times and it makes API request fail