This repository was archived by the owner on Dec 5, 2021. It is now read-only.
Some generic exceptions refactored into custom and specific exceptions#410
Open
mykolasglinskis wants to merge 4 commits intosochix:masterfrom
Open
Some generic exceptions refactored into custom and specific exceptions#410mykolasglinskis wants to merge 4 commits intosochix:masterfrom
mykolasglinskis wants to merge 4 commits intosochix:masterfrom
Conversation
Collaborator
|
Thanks for your contribution! You don't need the |
Collaborator
|
(PS: You don't need to close this PR and open a new one to be able to make changes.) |
Contributor
Author
|
removed interpolation |
Collaborator
|
Your last commit is introducing unnecessary diff noise, did you change the line endings or something? |
Collaborator
|
hello? |
Collaborator
|
@mykolasglinskis ping? |
Contributor
|
@knocte so the original poster wont answer anymore so i propose to close this PR and i Open another with the same changes so PR can merge into project. what do you think? |
Collaborator
|
@masihakbari yeah sure, we can close this one when you have opened a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.