Skip to content
This repository was archived by the owner on Jun 30, 2026. It is now read-only.

Implement more robust NavigationarHeight computation #127

Open
JWvanV wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Implement more robust NavigationarHeight computation #127

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10e5761
Implement more robust NavigationarHeight computation.
JWvanV Dec 8, 2016
8098567
Update dependencies
JWvanV Dec 8, 2016
cebabe8
Revert "Update dependencies"
JWvanV Dec 8, 2016
9e60c62
Update all dependencies to 25.0.1, needed minSKD to 9 (2.3+, which I …
JWvanV Dec 8, 2016
bd1d2c5
Revert "Update all dependencies to 25.0.1, needed minSKD to 9 (2.3+, …
JWvanV Dec 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 25 additions & 29 deletions library/src/main/java/com/cocosw/bottomsheet/TranslucentHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
import android.content.res.TypedArray;
import android.os.Build;
import android.util.DisplayMetrics;
import android.view.KeyCharacterMap;
import android.view.KeyEvent;
import android.view.ViewConfiguration;
import android.view.Window;
import android.view.WindowManager;
Expand Down Expand Up @@ -101,40 +103,34 @@ private float getSmallestWidthDp(WindowManager wm) {
return Math.min(widthDp, heightDp);
}

int getNavigationBarHeight(Context context) {
Resources res = context.getResources();
int result = 0;
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH) {
if (hasNavBar(context)) {
String key;
if (mInPortrait) {
key = NAV_BAR_HEIGHT_RES_NAME;
} else {
if (!isNavigationAtBottom())
return 0;
key = NAV_BAR_HEIGHT_LANDSCAPE_RES_NAME;
}
return getInternalDimensionSize(res, key);
}
public int getNavigationBarHeight(Context context) {
return getNavigationBarHeight(context, false);
}

public int getNavigationBarHeight(Context context, boolean skipRequirement) {
int resourceId = context.getResources().getIdentifier(NAV_BAR_HEIGHT_RES_NAME, "dimen", "android");
if (resourceId > 0 && (skipRequirement || hasNavBar(context))) {
return context.getResources().getDimensionPixelSize(resourceId);
}
return result;
return 0;
}

private boolean hasNavBar(Context context) {
Resources res = context.getResources();
int resourceId = res.getIdentifier(SHOW_NAV_BAR_RES_NAME, "bool", "android");
if (resourceId != 0) {
boolean hasNav = res.getBoolean(resourceId);
// check override flag (see static block)
if ("1".equals(sNavBarOverride)) {
hasNav = false;
} else if ("0".equals(sNavBarOverride)) {
hasNav = true;
}
return hasNav;
} else { // fallback
return !ViewConfiguration.get(context).hasPermanentMenuKey();
// Kitkat and less shows container above nav bar
if (android.os.Build.VERSION.SDK_INT <= Build.VERSION_CODES.KITKAT) {
return false;
}
// Emulator
if (Build.FINGERPRINT.startsWith("generic")) {
return true;
}
boolean hasMenuKey = ViewConfiguration.get(context).hasPermanentMenuKey();
boolean hasBackKey = KeyCharacterMap.deviceHasKey(KeyEvent.KEYCODE_BACK);
boolean hasNoCapacitiveKeys = !hasMenuKey && !hasBackKey;
Resources resources = context.getResources();
int id = resources.getIdentifier(SHOW_NAV_BAR_RES_NAME, "bool", "android");
boolean hasOnScreenNavBar = id > 0 && resources.getBoolean(id);
return hasOnScreenNavBar || hasNoCapacitiveKeys || getNavigationBarHeight(context, true) > 0;
}

private int getInternalDimensionSize(Resources res, String key) {
Expand Down