Conversation
snwagh
requested changes
Jul 30, 2024
snwagh
left a comment
snwagh
left a comment
Owner
There was a problem hiding this comment.
I have added a few comments. Given that there are significant changes, if you could add a good PR description, I can make a branch and merge your changes into that branch.
| @@ -1 +1,2 @@ | |||
| .DS_Store | |||
| ./src/*.o No newline at end of file | |||
Owner
There was a problem hiding this comment.
I see some .o files in the commit, something like *.o might work.
|
|
||
| RUN cd Falcon \ | ||
| && make all -j$(nproc) | ||
| RUN git clone https://github.com/trhieung/falcon-public Falcon |
Owner
There was a problem hiding this comment.
If you're pushing these changes upstream, can you edit the repo address to link to https://github.com/snwagh/falcon-public.git.
| @@ -0,0 +1,120 @@ | |||
| # Hướng dẫn traning model với falcon | |||
Owner
There was a problem hiding this comment.
Maybe rename the file with the language tutorial_<language_code>.md or even better, README_language.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.