[MIST-1139] Integrate replaying upon recovery#1140
Open
kyungissac wants to merge 2 commits intosnuspl:masterfrom
Open
[MIST-1139] Integrate replaying upon recovery#1140kyungissac wants to merge 2 commits intosnuspl:masterfrom
kyungissac wants to merge 2 commits intosnuspl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1139 by :
ReplayServerAddressandReplayServerPortparametersstartmethod ofQueryStarterclass tostartOrSetupForReplaybecause most of the code for both are the samereplayAndStartmethod toQueryStarterclasssetupmethod forMqttDataGeneratorclass (subscribe but do not emit data. This is for at-least-once event emission.)recoverGroupofcheckpointManagerclass to handle setup and replay/start separatelysetupQueryWithCheckpointtoQueryManagerclasssendMsgstoEventReplayUtilsfor sending replay messages in chronological orderCloses #1139