Skip to content

Agent classification enrichment - #1822

Open
Ian Streeter (istreeter) wants to merge 5 commits into
mainfrom
agent-classification-enrichment
Open

Agent classification enrichment#1822
Ian Streeter (istreeter) wants to merge 5 commits into
mainfrom
agent-classification-enrichment

Conversation

@istreeter

@istreeter Ian Streeter (istreeter) commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What changed?

Why?

Reviewer guidance

AI reviews

Claude will automatically review this PR against the docs style guide.

If you have questions or want it to look again at something specific, tag @claude in a comment.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs		 documentation e1dd1b7 Commit Preview URL

Branch Preview URL		 Jul 31 2026, 03:24 PM

@claude

claude Bot commented Jun 10, 2026

Copy link
Copy Markdown

Style & writing review

This PR is well-written and compliant with the style guide and CLAUDE.md. Frontmatter is complete and correctly formatted, terminology is correct (Snowplow CDI, Console with no article, YAUAA, Enrich, entity/event/schema casing), headings use sentence case, lists follow the capitalization/no-terminal-period rules, all internal links end in /index.md and resolve, the SchemaProperties and Tabs/TabItem components are used correctly, and ✅/❌ are used appropriately in tables. The external iglucentral schema reference resolves. Self-Hosted as a tab label matches the existing convention across the other enrichment pages, so that is fine.

One minor, optional item:

For Self-Hosted, [provide a complete JSON]...

Using JSON as a standalone count noun ("a complete JSON") reads a little awkwardly. Consider "provide a complete JSON configuration" (or "JSON document") for clarity. Not a blocker.

Nothing else material to flag.

@istreeter Ian Streeter (istreeter) mentioned this pull request Jun 10, 2026
Merged
benjben
Benjamin BENOIST (benjben) approved these changes Jun 11, 2026
View reviewed changes
Comment thread docs/pipeline/enrichments/available-enrichments/agent-classification-enrichment/index.md

| Field | Type | Description |
| --- | --- | --- |
| `uri` | string | Base URI where the file is hosted. Supports `http:`, `s3:`, and `gs:` schemes. Must not end with a trailing slash. |

@benjben Benjamin BENOIST (benjben) Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abfs also.

@stanch Nick (stanch) Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t we use https:// for that?

Comment thread docs/pipeline/enrichments/available-enrichments/agent-classification-enrichment/index.md Outdated
@stanch Nick (stanch) added the do not merge Flag to denote a Issue or PR which should not yet be merged (usually pending a release) label Jun 26, 2026
@stanch @benjben
Apply suggestion from @benjben
f464b64 
Co-authored-by: Benjamin BENOIST <benjamin.benoist@snowplowanalytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stanch Nick (stanch) stanch approved these changes
@benjben Benjamin BENOIST (benjben) benjben approved these changes

Assignees

No one assigned

Labels

do not merge Flag to denote a Issue or PR which should not yet be merged (usually pending a release)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@istreeter @stanch @benjben