feat: Chrome theme + review fixes (v2)#113
Open
yukazakiri wants to merge 1 commit intosnowarch:prereleasefrom
Open
feat: Chrome theme + review fixes (v2)#113yukazakiri wants to merge 1 commit intosnowarch:prereleasefrom
yukazakiri wants to merge 1 commit intosnowarch:prereleasefrom
Conversation
5 tasks
Chrome theme improvements: - Add chromium.theme contract file for reliable color resolution - Add BrowserColorScheme policy alongside BrowserThemeColor - Add elevate() with pkexec fallback + polkit agent detection - Add ensure_policy_dir_writable() for auto-setup of policy dirs - Add resolve_variant() for scheme-type Chrome theming - Prefer surface_container_low over primary for theme color - Fix variant name mapping (scheme-tonal-spot → tonal_spot) - Add Omarchy fork detection for CLI flag theming Review feedback addressed: - Restore updateLogPath, updateStatusPath, todoTxtPath in Directories.qml (actively consumed by ShellUpdates.qml, Todo.qml, TodoWidget.qml) - Keep hasExplicitTermColors so presets can ship custom terminal palettes - Keep SCSS writing in writeGeneratedThemeContracts() to prevent stale SCSS after preset changes - Keep original saturation/lightness clamps (0.85/0.75) and gentle harmony shift with maxShift cap - Add polkit agent detection in elevate() to avoid silent pkexec failures Other changes carried forward: - GameMode: fullscreen auto-detection + suppress notifications toggle - NiriService: minor fixes - Notifications: minor fixes - YtMusic: register config keys, persist volume - Settings: chrome theme toggle, game mode config - switchwall.sh: chromium theme integration
yukazakiri
force-pushed
the
fix/chrome-theme-v2
branch
from
05a91d5 to
597123b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chrome/Chromium/Brave theme integration with the Material You color pipeline, addressing all review feedback from PR #102. This is a clean single-commit branch rebased directly against
prerelease.Chrome theme improvements
chromium.themecontract file for reliable color resolutionBrowserColorSchemepolicy alongsideBrowserThemeColorelevate()with pkexec fallback + polkit agent detectionensure_policy_dir_writable()for auto-setup of policy dirsresolve_variant()for scheme-type Chrome themingsurface_container_lowoverprimaryfor theme colorscheme-tonal-spot→tonal_spot)Review feedback addressed
updateLogPath,updateStatusPath,todoTxtPathin Directories.qml — actively consumed by ShellUpdates.qml, Todo.qml, and TodoWidget.qmlhasExplicitTermColors— presets can still ship custom terminal color palettes (term1–term14)writeGeneratedThemeContracts()— prevents stale SCSS after preset changesmaxShiftcapelevate()— avoids silent pkexec failures on systems without a running polkit agentOther changes carried forward
switchwall.sh: chromium theme integrationTesting
inir restart && inir logs— no errorselevate()on a system without polkit agent (should log warning, not hang)Notes
Supersedes #102 with a clean rebase against
prerelease(no Zed redundancy — already merged via #98).