Repository navigation
Release 0.7.1: fix the From and To time fields - #29
Merged
Merged
Conversation
The menu filled its fields from the range on screen in an effect that also tracked the range, which moves with the clock and the store, so every refresh wiped what was being typed. Fill them only when the menu opens. From and To are now text fields read like the range box, with a calendar button that opens the browser's picker; segmented date fields were hard to type into. Tests type them key by key and wait through a refresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the From and To fields of the time range menu from 0.7.0, and releases 0.7.1 when merged.
Bug 1: typed times were wiped. The menu filled its fields from the range on screen inside an effect that also tracked that range. The range moves with the clock and the store (the oldest stored line), so every few seconds the effect ran again and put both fields and the typed range back. A time being entered vanished before it could be shown. The fields are now filled only when the menu opens.
Bug 2: the date fields were hard to type into. Chromium's
datetime-localsplits the value into small parts; the year part takes up to six digits, so typing a date and a time in one go never reached the time. From and To are now plain text fields with a calendar button that opens the browser's own picker (showPicker()).2026-11-10 08:15,10.11. 8:15,yesterday 14:00,14:00or2h ago. The line under each field shows how it was read, or "Not a time yet".Tests
The 0.7.0 test set the fields with Playwright
fill(), which writes the value directly and never waited through a refresh. That is why it passed. New tests:UI tests 36/36 (read-only project included),
npm run checkclean.Release
Bumps the version to 0.7.1 (Cargo, ui, desktop) and adds the CHANGELOG section. Merging releases it.