Repository navigation
Small fixes from the review - #25
Merged
Merged
Conversation
- --host beyond this computer answers any IP address of the machine (names stay refused) and warns that the link travels unencrypted - A settings file that cannot be read is set aside as config.broken.json; Stackline starts with the defaults and says so in the UI - CSV cells that start like a formula start with an apostrophe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after "Store and collector fixes from the review".
Changes
config.broken.jsonand Stackline starts with defaults. A banner says so, instead of failing to start.--host 0.0.0.0: this now works. Requests addressed to any IP address with the right port are answered, while names are still refused, which keeps DNS rebinding out. Stackline warns that the link travels unencrypted.= + - @) get a leading'.Tests
cargo test, clippy, fmt andnpm run checkpass.