Fix 403 errors when opening valid chat rooms - #21
Merged
Conversation
|
Deployment failed for project syncchat with the following error: Learn More: https://vercel.com/smshagor-devs-projects?upgradeToPro=build-rate-limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes false 403 responses triggered by auxiliary room requests when opening a valid chat, while also adding an explicit authorization guard to the main room-message endpoint.
Root cause
Several room APIs trusted only
inbox.ownersId. Group/channel membership is canonically stored inparticipantsId, so legacy or stale inbox ownership could reject a valid member with 403. Opening a room triggers pins, drafts, topics/E2EE requests, which made the browser reportFailed to load resource: 403even for an accessible room.Fix
roomAccessmiddleware.participantsIdmembership.inbox.ownersId, repair the inbox membership before existing controller checks continue.GET /chats/:roomIdso authenticated non-members cannot fetch room history by guessing a room ID.Scope
Backend access-control and membership consistency only. No message format, Socket.IO, call, UI, E2EE cryptography, or routing behavior is removed.