refactor(web): split app.js into per-view modules + shared UI helpers#73
Open
smochan wants to merge 3 commits into
Open
refactor(web): split app.js into per-view modules + shared UI helpers#73smochan wants to merge 3 commits into
smochan wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
codegraph PR reviewDiff vs main · severity ≤
|
| severity | rule | kind | qualname | file:line | score | message |
|---|---|---|---|---|---|---|
| critical | removed-referenced | graph | codegraph.web.static.app.esc |
codegraph/web/static/app.js:864 | 50 | Removed symbol still referenced by callers |
| critical | removed-referenced | graph | codegraph.web.static.app.mermaidThemeVars |
codegraph/web/static/app.js:65 | 50 | Removed symbol still referenced by callers |
| critical | removed-referenced | graph | codegraph.web.static.app.pyvisHref |
codegraph/web/static/app.js:799 | 50 | Removed symbol still referenced by callers |
| low | new-dead-code | graph | codegraph.web.static.views.flows._selectFlow |
codegraph/web/static/views/flows.js:54 | 10 | Potentially unreachable new code |
Triggered by codegraph CI · last run
Merged
5 tasks
codegraph PR reviewDiff vs main · severity ≤
|
| severity | rule | kind | qualname | file:line | score | message |
|---|---|---|---|---|---|---|
| critical | removed-referenced | graph | codegraph.web.static.app.esc |
codegraph/web/static/app.js:864 | 50 | Removed symbol still referenced by callers |
| critical | removed-referenced | graph | codegraph.web.static.app.mermaidThemeVars |
codegraph/web/static/app.js:65 | 50 | Removed symbol still referenced by callers |
| critical | removed-referenced | graph | codegraph.web.static.app.pyvisHref |
codegraph/web/static/app.js:799 | 50 | Removed symbol still referenced by callers |
| low | new-dead-code | graph | codegraph.web.static.views.flows._selectFlow |
codegraph/web/static/views/flows.js:54 | 10 | Potentially unreachable new code |
Triggered by codegraph CI · last run
4 tasks
codegraph PR reviewDiff vs main · severity ≤
|
| severity | rule | kind | qualname | file:line | score | message |
|---|---|---|---|---|---|---|
| high | new-untested-hotspot | graph | codegraph.web.static.ui.helpers.CGUI.formatQn |
codegraph/web/static/ui/helpers.js:22 | 0 | New function with 5 callers and no test coverage |
Triggered by codegraph CI · last run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track A2, stacked on #69. Pure extraction, zero behavior change:
app.js: 919 → 240 lines — keeps only data fetch, render dispatcher, sidebar/theme shellviews/overview|hld|flows|matrix|sankey|treemap.js) exposed viawindow.CGViews.*ui/helpers.js: shared esc/format/tooltip/toast/mermaid-theme/kind helpers viawindow.CGUI.*with per-view destructuring (matches the repo's no-bundler script-tag architecture)Implemented by a Sonnet subagent against a Fable spec; reviewed (namespace wiring,
window.stateexposure, node --check on every file, payload smoke test) by the orchestrating session.Test plan
🤖 Generated with Claude Code
Recreated from #70 (auto-closed when its stacked base branch was deleted during the merge train).