Skip to content

chore(config): remove vestigial mcp.enabled block#55

Merged
smochan merged 1 commit into
mainfrom
chore/remove-dead-mcp-config
May 30, 2026
Merged

chore(config): remove vestigial mcp.enabled block#55
smochan merged 1 commit into
mainfrom
chore/remove-dead-mcp-config

Conversation

@smochan

@smochan smochan commented May 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Drop the never-read `mcp` field from `CodegraphConfig`.
  • `model_config = {"extra": "ignore"}` keeps old configs forward-compatible.

v0.1.2 backlog item #7.

Test plan

  • 3 unit tests in `tests/test_config_mcp_removal.py`: old config still loads, fresh config doesn't emit it, other unknown fields also silently dropped.
  • Full suite green via pre-push hook.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

codegraph PR review

Diff vs main · severity ≤ high

codegraph review (target: main)

Diff: +6 / -0 / ~0 nodes, +20 / -0 edges

Findings (0)

No findings.

Triggered by codegraph CI · last run

@smochan smochan force-pushed the chore/remove-dead-mcp-config branch from 16850c7 to 6947cf6 Compare May 30, 2026 17:11
@github-actions

Copy link
Copy Markdown

codegraph PR review

Diff vs main · severity ≤ high

codegraph review (target: main)

Diff: +67 / -0 / ~0 nodes, +273 / -1 edges

Findings (0)

No findings.

Triggered by codegraph CI · last run

The `mcp:` field in `.codegraph.yml` was never read by any code path.
Sitting next to the active `register_mcp: true`, it confused users into
thinking it had to be flipped on manually.

Removed from `CodegraphConfig`. `model_config = {"extra": "ignore"}`
keeps forward-compat: existing 0.1.x configs that still carry the
field load without error.

v0.1.2 backlog item #7.
@smochan smochan force-pushed the chore/remove-dead-mcp-config branch from 6947cf6 to 21bb079 Compare May 30, 2026 17:49
@github-actions

Copy link
Copy Markdown

codegraph PR review

Diff vs main · severity ≤ high

codegraph review (target: main)

Diff: +6 / -0 / ~0 nodes, +20 / -0 edges

Findings (0)

No findings.

Triggered by codegraph CI · last run

@smochan smochan merged commit da3acb9 into main May 30, 2026
5 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant