chore: sync .claude extension template and clear markdownlint debt - #39
Merged
Conversation
Wave 3 of the standards-check rollout. This repo was red on shellcheck and markdownlint. shellcheck: every finding was in .claude/hooks/extensions/example.sh.disabled, a copied template that is never executed. SC2155/SC2329/SC2312, all already fixed upstream in smartwatermelon/dev-env#102. The copy here is byte-identical to dev-env at 404218c, the revision immediately before that fix, so this is a pure forward update to an already-reviewed file rather than a local edit. Provenance was verified by matching the file's md5 against dev-env's history for that path. markdownlint: MD040 (untagged fence around a directory tree, now `text`) and MD041 (LICENSE.md opened with the plain-text line "MIT License", now an h1 — the license text itself is untouched). Verified with the CI runner rather than the linter alone: run-standards.sh --repo <this repo> now exits 0 with no errors from any of the six linters. The whole repo is cleared in one commit deliberately. standards-check scans the entire repo on every PR, so a partial fix would leave the check red on its own PR and pre-merge-review.sh would block the very commit that clears the debt (smartwatermelon/dev-env#106). Claude-Session: https://claude.ai/code/session_01UaPoEix1iED8ENCZCa12jy
|
Changes are limited to VERDICT: PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
This repo failed
standards-checkon shellcheck and markdownlint.shellcheck — every finding was in
.claude/hooks/extensions/example.sh.disabled, a copied template that isnever executed (the
.disabledsuffix stops the global hook sourcing it).SC2155/SC2329/SC2312, already fixed upstream in smartwatermelon/dev-env#102.
Provenance verified, not assumed: this file's md5 matches dev-env at
404218cexactly — the revision immediately before that fix — so this is aforward update to an already-reviewed file, not a local edit.
markdownlint — MD040 (an untagged fence around a directory tree, now
text) and MD041 (LICENSE.mdopened with the plain-text lineMIT License, now an h1; the license text itself is untouched).Verification
The same runner was run before the fix as a known-bad control and
reproduced these exact findings.
Why the whole repo, in one commit
standards-checkscans the entire repo on each PR run, andpre-merge-review.shblocks on failing checks regardless of whether they arerequired (smartwatermelon/dev-env#106). A partial fix would leave the check red
on its own PR and block the very commit that clears the debt.
Wider finding
Six fleet repos carry this identical stale template, and
repo-templatedoestoo — so every new repo is born failing
standards-check. Root cause:smartwatermelon/dev-env#62.
https://claude.ai/code/session_01UaPoEix1iED8ENCZCa12jy