chore: restore self-applying caller for dogfooding + required status check - #41
Merged
Merged
Conversation
…s check Branch protection on main requires the `claude-review / run-review` status check, but no workflow in this repo produces it. The caller that used to produce it (.github/workflows/claude-code-review.yml) was removed in commit 52e688b as part of the v1 rename, and nothing was added back. Since then every PR (#33–#36, #39) has been BLOCKED on main's branch protection and only mergeable via `--admin`, losing both the enforcement and the dogfooding of the reusable workflow on its own changes. Add .github/workflows/self-review.yml, a minimal caller that: - Triggers on pull_request (opened/synchronize/ready_for_review/reopened) - Invokes the reusable workflow via LOCAL path (./.github/workflows/...) so PR branches review their proposed changes to the reusable workflow against themselves before release. A tag-pinned reference (@v1) would run the released version instead and miss bugs introduced in the PR. - Names the calling job `claude-review`, matching the required status check name `claude-review / run-review` in branch protection. - Passes repo-specific extra_instructions flagging the sensitive surfaces in this repo: shell-injection in PR-data interpolation, verdict contract stability, allowed-tools broadening, and the escape-hatch regex (which just bit us in #38). No functional changes to the reusable workflow itself. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/self-review.yml, a minimal caller that invokes the reusableclaude-blocking-review.ymlon this repo's own PRsclaude-review / run-reviewstatus check thatmain's branch protection requires (and that no workflow has produced since commit 52e688b removed the prior caller during the v1 rename)./.github/workflows/claude-blocking-review.yml), not a tag reference, so PR branches dogfood the proposed changes to the reusable workflow against themselves — not the released@v1versionWhy
Every PR since
52e688b(March 27) has beenmergeStateStatus: BLOCKEDand mergeable only via--admin:Restoring the self-caller means:
What this PR does NOT change
Verification
Self-Review / claude-review / run-reviewcheck should appear)gh pr merge(no--admin), confirming the fix end-to-endRelated
Test plan
Self-Review / claude-review / run-reviewappears on this PR and runsgh pr merge <this>works without--admin🤖 Generated with Claude Code