fix(blocking-review): require line-level evidence for regression BLOCKs - #4
Merged
twistedmelonman merged 1 commit intoFeb 26, 2026
Conversation
Two targeted prompt improvements based on observed false-positive BLOCKs on PR #841/#842: 1. Add EVIDENCE STANDARD section after the PASS/BLOCK criteria: when claiming a test or code path will regress, the reviewer must trace the execution path to a specific failing assertion with line citations. Assumed execution order that isn't verified in the diff must downgrade to PASS + observation. Includes ❌/✓ examples using the actual failure patterns from the incident. 2. Add observation ordering guidance: non-blocking observations should be ordered by maintenance impact (things that cause test drift first, stylistic notes last). The reviewer cannot run tests (claude_args restricts to gh/cat/echo/tee), so confidence about test failures must come from traceable code analysis, not inference. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
twistedmelonman
deleted the
claude/fix-blocking-review-evidence-standard-1772055
branch
February 26, 2026 02:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Based on observed false positives from PR #841/#842 (2026-02-25):
validateEntitlements()was called beforeCLAUDE_API_KEYwas checked — the actual code order was the opposite. Three CI round-trips wasted.claude_argsrestricts tools togh pr diff,gh pr view,cat,echo,tee), so confidence about test failures must come from traceable code analysis.The examples in the new EVIDENCE STANDARD section are drawn directly from the incident, making them concrete anchors rather than abstract rules.
Test plan
🤖 Generated with Claude Code