Skip to content

fix(blocking-review): require line-level evidence for regression BLOCKs - #4

Merged
twistedmelonman merged 1 commit into
mainfrom
claude/fix-blocking-review-evidence-standard-1772055
Feb 26, 2026
Merged

fix(blocking-review): require line-level evidence for regression BLOCKs#4
twistedmelonman merged 1 commit into
mainfrom
claude/fix-blocking-review-evidence-standard-1772055

Conversation

@twistedmelonman

Copy link
Copy Markdown
Member

Summary

  • Evidence standard for regression BLOCKs: When the reviewer claims a test or code path will regress, it must now trace the execution path to a specific failing assertion with line citations. If the trace relies on assumed execution order not verified in the diff or source, it must downgrade to PASS + observation instead of issuing a BLOCK.
  • Observation ordering: Non-blocking observations should lead with highest maintenance-impact items (things that will cause test drift or duplicate bugs) before stylistic notes.

Motivation

Based on observed false positives from PR #841/#842 (2026-02-25):

  • The reviewer issued a BLOCK claiming a 503 test would fail because validateEntitlements() was called before CLAUDE_API_KEY was checked — the actual code order was the opposite. Three CI round-trips wasted.
  • Root cause: the reviewer inferred execution order rather than tracing the actual call path in the source.
  • The reviewer cannot run tests (claude_args restricts tools to gh pr diff, gh pr view, cat, echo, tee), so confidence about test failures must come from traceable code analysis.

The examples in the new EVIDENCE STANDARD section are drawn directly from the incident, making them concrete anchors rather than abstract rules.

Test plan

  • Review the prompt changes in the workflow file for correctness
  • Confirm the ❌/✓ examples accurately reflect the intended policy
  • Confirm no structural changes to the verdict mechanism (Steps 1–4 unchanged)

🤖 Generated with Claude Code

Two targeted prompt improvements based on observed false-positive BLOCKs
on PR #841/#842:

1. Add EVIDENCE STANDARD section after the PASS/BLOCK criteria: when claiming
   a test or code path will regress, the reviewer must trace the execution path
   to a specific failing assertion with line citations. Assumed execution order
   that isn't verified in the diff must downgrade to PASS + observation.
   Includes ❌/✓ examples using the actual failure patterns from the incident.

2. Add observation ordering guidance: non-blocking observations should be
   ordered by maintenance impact (things that cause test drift first,
   stylistic notes last).

The reviewer cannot run tests (claude_args restricts to gh/cat/echo/tee),
so confidence about test failures must come from traceable code analysis,
not inference.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@twistedmelonman
twistedmelonman merged commit 18bab15 into main Feb 26, 2026
2 checks passed
@twistedmelonman
twistedmelonman deleted the claude/fix-blocking-review-evidence-standard-1772055 branch February 26, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant