Skip to content

fix: warn on too-short sha= marker in Minimize PASS review comment step #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twistedmelonman merged 3 commits into from
Aug 8, 2026
Merged

fix: warn on too-short sha= marker in Minimize PASS review comment step #104

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31229ca
fix: warn on too-short sha= marker in Minimize PASS review comment step
Aug 8, 2026
61b9aa8
Merge branch 'main' into claude/fix-minimize-pass-short-sha-warning-9…
twistedmelonman Aug 8, 2026
a7abd7c
Merge branch 'main' into claude/fix-minimize-pass-short-sha-warning-9…
twistedmelonman Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/claude-blocking-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,14 @@ jobs:
if [ -z "$MARKER_SHA" ]; then
echo "[skip-claude-review] unscoped override active — nothing to minimize."
exit 0
elif [ "${#MARKER_SHA}" -ge 7 ] && [ "${SHA#"$MARKER_SHA"}" != "$SHA" ]; then
elif [ "${#MARKER_SHA}" -lt 7 ]; then
# Mirrors the "Check review verdict" step's rejection of
# too-short sha= values (#92) — log the same warning here so
# an operator debugging why a PASS comment wasn't minimized
# sees the same too-short-marker explanation in both steps'
# logs, instead of this step silently falling through.
echo "::warning::[skip-claude-review sha=${MARKER_SHA}] marker rejected — sha= value must be at least 7 characters. Proceeding with minimize check."
elif [ "${SHA#"$MARKER_SHA"}" != "$SHA" ]; then
echo "[skip-claude-review sha=${MARKER_SHA}] override active for current head — nothing to minimize."
exit 0
fi
Expand Down
Loading