[ASQ-1255] Fixed syntax for I18n call and Rspec::Matchers deprecation for Ruby 3 support#1
Open
micaelacunhadev wants to merge 2 commits intomasterfrom
Open
[ASQ-1255] Fixed syntax for I18n call and Rspec::Matchers deprecation for Ruby 3 support#1micaelacunhadev wants to merge 2 commits intomasterfrom
micaelacunhadev wants to merge 2 commits intomasterfrom
Conversation
micaelacunhadev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch was created when upgrading ASQ's Ruby version to 3.0 in the scope of ticket ASQ-986.
It includes a fix on the syntax to call I18n, made by Stone Filipczak, and a fix to address the deprecation of the RSpec Matchers, as described in the RSpec documentation.
Motivation and Context
ASQ-1255 - Upgrade SmartLogic gems used in ASQ
ASQ-986 - Upgrade ASQ from Ruby 2.7 -> 3.0
Notes
After this branch is merged, should a tag be created instead and the ASQ Gemfile updated accordingly? If yes, what should the tag version number look like?