feat: add GH action - #37
Conversation
|
@olsova is it still a draft? |
| fi | ||
| echo "Config file found: ${{ inputs.type }}" | ||
|
|
||
| - name: Build and Run Docker Container |
There was a problem hiding this comment.
I think we don’t need the Docker container anymore.
Previously (before the GitHub Action), we used a GitHub App for atc.
It was supposed to always run and listen for webhooks. When we received a push event, we checked the config file, compared versions, etc.
But now we don’t need this.
Users will use the push trigger, so we just need to compare versions and push tags (if needed).
So what we need to build the binary + run the built binary with CI_MODE env
There was a problem hiding this comment.
does the regular mod (with webhooks) work for this dockerfile?
DmitriyLewen
left a comment
DmitriyLewen
left a comment
There was a problem hiding this comment.
Can you create test repo with lock file (e.g. package.json or pom.xml) and test this action?
| shell: bash | ||
| run: | | ||
| go build -o atc ./ | ||
| chmod +x atc |
There was a problem hiding this comment.
atc is already executable, no?
| - name: Build Automated Tag Creator | ||
| shell: bash | ||
| run: | | ||
| go build -o atc ./ |
There was a problem hiding this comment.
Go is not preinstalled on the latest Ubuntu runner:
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
5128bf7 to
95ac33e
Compare
3635b25 to
22200b0
Compare
|
@DmitriyLewen I don't have merge access. Could you merge this PR? |
3 participants
add a yaml file to allow using atc as a GH action
test run: https://github.com/olsova/atc-test/actions/runs/19860330864