chore: replacing block depth from 10 with 32 everywhere#1
Conversation
|
👋 Genesis3800, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR updates the tutorial documentation and deploy-script “next step” commands to use a block depth of 32 (instead of 10) when configuring BLOCK_DEPTH finality, aligning all Hardhat and Foundry tutorial flows with the newer recommended value.
Changes:
- Replaced
ALLOWED_BLOCK_DEPTH=10→ALLOWED_BLOCK_DEPTH=32in Hardhat and Foundry tutorial READMEs and deploy-script printed commands. - Replaced
BLOCK_DEPTH=10→BLOCK_DEPTH=32in tutorial usage examples (including an ASCII-box usage comment in a Foundry script). - Verified there are no remaining
ALLOWED_BLOCK_DEPTH=10/BLOCK_DEPTH=10occurrences in the repository after these updates.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hardhat/scripts/tutorials/transfer-usdc-with-data/README.md | Updates configuration + send examples to BLOCK_DEPTH=32. |
| hardhat/scripts/tutorials/transfer-usdc-with-data/deploy/deploy.ts | Updates printed next-step config command to ALLOWED_BLOCK_DEPTH=32. |
| hardhat/scripts/tutorials/send-arbitrary-data/README.md | Updates configuration + send examples to BLOCK_DEPTH=32. |
| hardhat/scripts/tutorials/send-arbitrary-data/deploy/deploy.ts | Updates printed config commands to ALLOWED_BLOCK_DEPTH=32. |
| hardhat/scripts/tutorials/send-arbitrary-data-and-receive-transfer-confirmation/README.md | Updates configuration + send examples to BLOCK_DEPTH=32. |
| hardhat/scripts/tutorials/send-arbitrary-data-and-receive-transfer-confirmation/deploy/deploy.ts | Updates printed config command to ALLOWED_BLOCK_DEPTH=32. |
| hardhat/scripts/tutorials/programmable-token-transfers/README.md | Updates allowlist configuration examples to ALLOWED_BLOCK_DEPTH=32. |
| hardhat/scripts/tutorials/programmable-token-transfers/deploy/deploy.ts | Updates printed config commands to ALLOWED_BLOCK_DEPTH=32. |
| hardhat/scripts/tutorials/programmable-defensive-token-transfers/README.md | Updates configuration + send examples to BLOCK_DEPTH=32. |
| hardhat/scripts/tutorials/programmable-defensive-token-transfers/deploy/deploy.ts | Updates printed config commands to ALLOWED_BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/transfer-usdc-with-data/README.md | Updates configuration + send examples to BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/transfer-usdc-with-data/deploy/Deploy.s.sol | Updates printed config command to ALLOWED_BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/send-arbitrary-data/README.md | Updates configuration + send examples to BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/send-arbitrary-data/interact/TestOutOfOrderExecution.s.sol | Updates usage comment example to BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/send-arbitrary-data/deploy/Deploy.s.sol | Updates printed config commands to ALLOWED_BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/send-arbitrary-data-and-receive-transfer-confirmation/README.md | Updates configuration + send examples to BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/send-arbitrary-data-and-receive-transfer-confirmation/deploy/Deploy.s.sol | Updates printed config command to ALLOWED_BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/programmable-token-transfers/README.md | Updates allowlist + example block depth usage to 32. |
| foundry/scripts/tutorials/programmable-token-transfers/deploy/Deploy.s.sol | Updates printed config commands to ALLOWED_BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/programmable-defensive-token-transfers/README.md | Updates configuration + send examples to BLOCK_DEPTH=32. |
| foundry/scripts/tutorials/programmable-defensive-token-transfers/deploy/Deploy.s.sol | Updates printed config commands to ALLOWED_BLOCK_DEPTH=32. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Block depth was 10 everywhere earlier, and that was causing issues. This PR fixes that