Skip to content

chore: replacing block depth from 10 with 32 everywhere#1

Merged
SyedAsadKazmi merged 1 commit into
mainfrom
correct-depth-pr
Jun 2, 2026
Merged

chore: replacing block depth from 10 with 32 everywhere#1
SyedAsadKazmi merged 1 commit into
mainfrom
correct-depth-pr

Conversation

@Genesis3800
Copy link
Copy Markdown
Contributor

Block depth was 10 everywhere earlier, and that was causing issues. This PR fixes that

@Genesis3800 Genesis3800 requested review from a team as code owners June 1, 2026 22:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

👋 Genesis3800, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the tutorial documentation and deploy-script “next step” commands to use a block depth of 32 (instead of 10) when configuring BLOCK_DEPTH finality, aligning all Hardhat and Foundry tutorial flows with the newer recommended value.

Changes:

  • Replaced ALLOWED_BLOCK_DEPTH=10ALLOWED_BLOCK_DEPTH=32 in Hardhat and Foundry tutorial READMEs and deploy-script printed commands.
  • Replaced BLOCK_DEPTH=10BLOCK_DEPTH=32 in tutorial usage examples (including an ASCII-box usage comment in a Foundry script).
  • Verified there are no remaining ALLOWED_BLOCK_DEPTH=10 / BLOCK_DEPTH=10 occurrences in the repository after these updates.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hardhat/scripts/tutorials/transfer-usdc-with-data/README.md Updates configuration + send examples to BLOCK_DEPTH=32.
hardhat/scripts/tutorials/transfer-usdc-with-data/deploy/deploy.ts Updates printed next-step config command to ALLOWED_BLOCK_DEPTH=32.
hardhat/scripts/tutorials/send-arbitrary-data/README.md Updates configuration + send examples to BLOCK_DEPTH=32.
hardhat/scripts/tutorials/send-arbitrary-data/deploy/deploy.ts Updates printed config commands to ALLOWED_BLOCK_DEPTH=32.
hardhat/scripts/tutorials/send-arbitrary-data-and-receive-transfer-confirmation/README.md Updates configuration + send examples to BLOCK_DEPTH=32.
hardhat/scripts/tutorials/send-arbitrary-data-and-receive-transfer-confirmation/deploy/deploy.ts Updates printed config command to ALLOWED_BLOCK_DEPTH=32.
hardhat/scripts/tutorials/programmable-token-transfers/README.md Updates allowlist configuration examples to ALLOWED_BLOCK_DEPTH=32.
hardhat/scripts/tutorials/programmable-token-transfers/deploy/deploy.ts Updates printed config commands to ALLOWED_BLOCK_DEPTH=32.
hardhat/scripts/tutorials/programmable-defensive-token-transfers/README.md Updates configuration + send examples to BLOCK_DEPTH=32.
hardhat/scripts/tutorials/programmable-defensive-token-transfers/deploy/deploy.ts Updates printed config commands to ALLOWED_BLOCK_DEPTH=32.
foundry/scripts/tutorials/transfer-usdc-with-data/README.md Updates configuration + send examples to BLOCK_DEPTH=32.
foundry/scripts/tutorials/transfer-usdc-with-data/deploy/Deploy.s.sol Updates printed config command to ALLOWED_BLOCK_DEPTH=32.
foundry/scripts/tutorials/send-arbitrary-data/README.md Updates configuration + send examples to BLOCK_DEPTH=32.
foundry/scripts/tutorials/send-arbitrary-data/interact/TestOutOfOrderExecution.s.sol Updates usage comment example to BLOCK_DEPTH=32.
foundry/scripts/tutorials/send-arbitrary-data/deploy/Deploy.s.sol Updates printed config commands to ALLOWED_BLOCK_DEPTH=32.
foundry/scripts/tutorials/send-arbitrary-data-and-receive-transfer-confirmation/README.md Updates configuration + send examples to BLOCK_DEPTH=32.
foundry/scripts/tutorials/send-arbitrary-data-and-receive-transfer-confirmation/deploy/Deploy.s.sol Updates printed config command to ALLOWED_BLOCK_DEPTH=32.
foundry/scripts/tutorials/programmable-token-transfers/README.md Updates allowlist + example block depth usage to 32.
foundry/scripts/tutorials/programmable-token-transfers/deploy/Deploy.s.sol Updates printed config commands to ALLOWED_BLOCK_DEPTH=32.
foundry/scripts/tutorials/programmable-defensive-token-transfers/README.md Updates configuration + send examples to BLOCK_DEPTH=32.
foundry/scripts/tutorials/programmable-defensive-token-transfers/deploy/Deploy.s.sol Updates printed config commands to ALLOWED_BLOCK_DEPTH=32.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SyedAsadKazmi SyedAsadKazmi merged commit 69c12d8 into main Jun 2, 2026
6 of 8 checks passed
@SyedAsadKazmi SyedAsadKazmi deleted the correct-depth-pr branch June 2, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants