Extract internal/creconfig for CLI config paths#463
Conversation
timothyF95
changed the title
|
| Version | Value |
|---|---|
| Current Fork | `` |
| Latest Upstream | v1.17.3 |
Action Required
- Review abigen changes in upstream (only the
accounts/abi/binddirectory matters) - Compare with our fork in
cmd/generate-bindings/bindings/abigen/ - If relevant changes exist, sync them and update
FORK_METADATA.md - If no abigen changes, just update the version in
FORK_METADATA.mdtov1.17.3
⚠️ Potential Security-Related Commits Detected
- p2p/nat: bump pion/stun to v3 to pull in fixed pion/dtls (#34980) (link)
- build: upgrade -dlgo version to Go 1.25.10 (#34911) (link)
Files to Review
cmd/generate-bindings/bindings/abigen/bind.gocmd/generate-bindings/bindings/abigen/bindv2.gocmd/generate-bindings/bindings/abigen/template.go
cc @smartcontractkit/bix-framework
| t.Helper() | ||
| dir := filepath.Join(home, credentials.ConfigDir) | ||
| if err := os.MkdirAll(dir, 0o700); err != nil { | ||
| dir, err := creconfig.EnsureDir() |
There was a problem hiding this comment.
Can we name the variable and function a bit more explicit? It looks quite generic now.
There was a problem hiding this comment.
IMO this does encapsulate precisely what it is. We have created a new package with specific ownership over your cre configuration creconfig which is in your home directory EnsureDir makes sure the directory exists. I did consider calling it something similar to creglobalconfig but we may want to extend this in the future to be split between global and local in a similar way that git differentiates between the two. Do you have any ideas of how we could make it more explicit?
There was a problem hiding this comment.
Maybe we could name the dir -> creConfigDir?
…smartcontractkit/cre-cli into DEVSVCS-5162/refactor-cliconfig
|
| Version | Value |
|---|---|
| Current Fork | `` |
| Latest Upstream | v1.17.3 |
Action Required
- Review abigen changes in upstream (only the
accounts/abi/binddirectory matters) - Compare with our fork in
cmd/generate-bindings/bindings/abigen/ - If relevant changes exist, sync them and update
FORK_METADATA.md - If no abigen changes, just update the version in
FORK_METADATA.mdtov1.17.3
⚠️ Potential Security-Related Commits Detected
- p2p/nat: bump pion/stun to v3 to pull in fixed pion/dtls (#34980) (link)
- build: upgrade -dlgo version to Go 1.25.10 (#34911) (link)
Files to Review
cmd/generate-bindings/bindings/abigen/bind.gocmd/generate-bindings/bindings/abigen/bindv2.gocmd/generate-bindings/bindings/abigen/template.go
cc @smartcontractkit/bix-framework
2 participants
Summary
internal/creconfigas the single owner of CLI config directory pathstenantctx,templateconfig,templaterepo/cache,update,telemetry, and relatedcmd/tests.crepath helpers from credentialshelp/docs