feat: implement ContractWriter for Stellar#121
Draft
Krish-vemula wants to merge 2 commits into
Draft
Conversation
Soroban Contract Test Coverage92.69% line coverage — 16441 / 17738 lines hit
Per-Contract Breakdown
Full file-level coverage report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR builds out the per-node
ContractWriterimplementation for Stellar, which satisfies thecommontypes.ContractWriterinterface. It enables the core node to submit translated Soroban transactions natively via the Stellar LOOP relayer.Architecture
chainlink-common's domain-typestellartypes.ScValdirectly intogo-stellar-sdk'sxdr.ScValinside the plugin. This prevents leaking chain-specific SDK dependencies up to the core node.TransmitterSelectoracross the localcore.Keystoreaccounts to prevent single-address sequence bottlenecks when no explicitFromAddressis configured.txnbuild.InvokeHostFunctionpayload throughtxm.Simulateprior to enqueueing to verify viability and trap any "restore footprint preamble" requirements.meta.GasLimitconfigurations from the core node by returningErrSettingTransactionGasLimitNotSupported. This correctly aligns with Soroban's architecture, where transaction-level gas limits cannot be manually overridden and are instead strictly derived from theSorobanTransactionDatafootprints generated during simulation.StellarTxminto atxm.TxManagerinterface and hooks the workflow up to pass idempotency keys directly to theEnqueuepipeline.References
chainlink-common/pkg/types/contract_writer.go