(Requires Audit) PLEX-2473 LogPoller switch to batch inserts (Part 2)#356
Open
dhaidashenko wants to merge 4 commits intofeature/PLEX-2473-fix-reorg-handing-on-replayfrom
Open
Conversation
Contributor
|
dhaidashenko
changed the title
dhaidashenko
changed the title
dhaidashenko
changed the title
Krish-vemula
approved these changes
Feb 17, 2026
Unheilbar
reviewed
Feb 17, 2026
pkg/logpoller/orm.go
Outdated
| return batchInsert(ctx, tx, q, logs, 4000) | ||
| } | ||
|
|
||
| func batchInsert[T any](ctx context.Context, ds sqlutil.DataSource, query string, objs []T, batchSize int) error { |
Collaborator
There was a problem hiding this comment.
unused parameter batchSize
| // Resume from the latest block saved. | ||
| return fmt.Errorf("failed to get current block: %w", err) | ||
|
|
||
| blocks, logs, err := lp.getUnfinalizedLogs(ctx, currentBlock, latestBlockNumber, safeBlockNumber, latestFinalizedBlockNumber, isReplay) |
Collaborator
There was a problem hiding this comment.
Should there be some batching as well? If a node is far behind, can this be potential OOM risk?
…ture/PLEX-2473-lp-batch-insert-blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insert blocks and logs in batches to reduce DB IO usage.
Depends on: #355