[BCI-3989][common] - CR methods err when service unstarted by Farber98 · Pull Request #705 · smartcontractkit/chainlink-common

Farber98 · 2024-08-14T16:48:16Z

solana ref: BCI-3989-cr-methods-error-when-unstarted
core ref: BCI-3989-cr-methods-error-when-unstarted

Task Description:

We only want GetLatestValue, BatchGetLatestValue and QueryKey to be called when CR service is in Started state. If CR is not started yet, we should return an error.

This PR:

Ticket:

BCI-3989

Unblocks:

Merging flow:

merge common (point to solana and core for CI to pass)
Then merge Solana by pointing to merged common
Finally merge core after changing Solana and common refs

This reverts commit 5006bec.

jmank88 · 2024-09-16T13:33:59Z

pkg/loop/internal/relayer/pluginprovider/contractreader/contract_reader_test.go

+			require.NoError(t, it.impl.Start(context.Background()))
+			t.Cleanup(func() { require.NoError(t, it.impl.Close()) })


Please use servicetest.Run. Notice it uses assert during cleanup.

…rted" This reverts commit 54d7016, reversing changes made to 4e67d8d.

…arted" This reverts commit e728084.

Farber98 · 2024-09-17T11:00:37Z

pkg/types/interfacetests/chain_components_interface_tests.go

 )

-type ChainComponentsInterfaceTester[T TestingT[T]] interface {
+type ChainComponentsTester[T any] interface {


defined ChainComponentsTester so we use the Setup(t T, startCR bool) only for chainComponents tests

defined chainComponentsTestcase so we use the startCR testcase flag only for chainComponents testcases

defined runChainComponentsTests to execute chainComponents specific tests using the ChainComponentsTester interface with Setup(t T, startCR bool)

Farber98 · 2024-09-17T11:09:10Z

pkg/types/interfacetests/codec_interface_tests.go

 	TestOn       string
 }

+type codecTestcase[T any] struct {


defined CodecTester so we use the Setup(t T) without the startCR flag for the codec

defined codecTestcase so we don't use the startCR testcase flag for codec testcases

defined runCodecTests to execute codec specific tests using the CodecTester interface with Setup(t T)

Farber98 · 2024-09-17T11:14:06Z

pkg/loop/internal/relayer/pluginprovider/contractreader/contract_reader_test.go

 		fake.stored = []TestStruct{}
+
+		if startCR {
+			servicetest.Run(t, it.impl)


added servicetest.Run(t, it.impl)

ilija42

Wdyt about this solution

#777
smartcontractkit/chainlink#14480

check cr service is started

352adfe

Farber98 temporarily deployed to integration August 14, 2024 16:48 — with GitHub Actions Inactive

Farber98 added 2 commits August 15, 2024 10:19

small refactor

173eca4

Merge branch 'main' into BCI-3989-cr-methods-error-when-unstarted

e16b694

Farber98 temporarily deployed to integration August 15, 2024 13:20 — with GitHub Actions Inactive

Farber98 had a problem deploying to integration August 15, 2024 13:20 — with GitHub Actions Error

Farber98 temporarily deployed to integration August 15, 2024 13:20 — with GitHub Actions Inactive

remove unused error

0d8a1b0

Farber98 temporarily deployed to integration August 15, 2024 13:24 — with GitHub Actions Inactive

bind before start

af1fabf

Farber98 temporarily deployed to integration August 15, 2024 14:23 — with GitHub Actions Inactive

Farber98 added 2 commits August 15, 2024 12:42

add comments to tests

4dcb052

startChainReader method

4d966e6

Farber98 temporarily deployed to integration August 15, 2024 15:45 — with GitHub Actions Inactive

Farber98 had a problem deploying to integration August 15, 2024 15:45 — with GitHub Actions Failure

Farber98 temporarily deployed to integration August 15, 2024 15:45 — with GitHub Actions Inactive

check methods return error when called without starting service

5006bec

Farber98 had a problem deploying to integration August 16, 2024 02:36 — with GitHub Actions Failure

Farber98 temporarily deployed to integration August 16, 2024 02:36 — with GitHub Actions Inactive

Revert "check methods return error when called without starting service"

cc3066b

This reverts commit 5006bec.

Farber98 had a problem deploying to integration August 16, 2024 03:03 — with GitHub Actions Failure

Farber98 temporarily deployed to integration August 16, 2024 03:03 — with GitHub Actions Inactive

Farber98 temporarily deployed to integration September 15, 2024 23:58 — with GitHub Actions Inactive

Farber98 had a problem deploying to integration September 15, 2024 23:58 — with GitHub Actions Failure

Farber98 temporarily deployed to integration September 16, 2024 00:04 — with GitHub Actions Inactive

jmank88 reviewed Sep 16, 2024

View reviewed changes

refactor codec and chaincomponents ifaces

4e67d8d

Farber98 had a problem deploying to integration September 16, 2024 21:14 — with GitHub Actions Error

Merge branch 'main' into BCI-3989-cr-methods-error-when-unstarted

54d7016

Farber98 had a problem deploying to integration September 16, 2024 21:27 — with GitHub Actions Error

Revert "Merge branch 'main' into BCI-3989-cr-methods-error-when-unsta…

e728084

…rted" This reverts commit 54d7016, reversing changes made to 4e67d8d.

Farber98 temporarily deployed to integration September 16, 2024 21:48 — with GitHub Actions Inactive

Farber98 temporarily deployed to integration September 16, 2024 22:03 — with GitHub Actions Inactive

Reapply "Merge branch 'main' into BCI-3989-cr-methods-error-when-unst…

953d786

…arted" This reverts commit e728084.

Farber98 temporarily deployed to integration September 17, 2024 10:57 — with GitHub Actions Inactive

Farber98 had a problem deploying to integration September 17, 2024 10:57 — with GitHub Actions Failure

Farber98 temporarily deployed to integration September 17, 2024 10:57 — with GitHub Actions Inactive

Farber98 commented Sep 17, 2024

View reviewed changes

Merge branch 'main' into BCI-3989-cr-methods-error-when-unstarted

f94c2c9

Farber98 temporarily deployed to integration September 17, 2024 11:23 — with GitHub Actions Inactive

Farber98 had a problem deploying to integration September 17, 2024 11:23 — with GitHub Actions Failure

Farber98 temporarily deployed to integration September 17, 2024 11:23 — with GitHub Actions Inactive

ilija42 requested changes Sep 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BCI-3989][common] - CR methods err when service unstarted#705

[BCI-3989][common] - CR methods err when service unstarted#705
Farber98 wants to merge 38 commits intomainfrom
BCI-3989-cr-methods-error-when-unstarted

Farber98 commented Aug 14, 2024 •

edited

Loading

Uh oh!

jmank88 Sep 16, 2024

Uh oh!

Farber98 Sep 17, 2024

Uh oh!

Farber98 Sep 17, 2024

Uh oh!

Farber98 Sep 17, 2024

Uh oh!

ilija42 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		require.NoError(t, it.impl.Start(context.Background()))
		t.Cleanup(func() { require.NoError(t, it.impl.Close()) })

Conversation

Farber98 commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task Description:

This PR:

Ticket:

Unblocks:

Merging flow:

Uh oh!

jmank88 Sep 16, 2024

Choose a reason for hiding this comment

Uh oh!

Farber98 Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

Farber98 Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

Farber98 Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

ilija42 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Farber98 commented Aug 14, 2024 •

edited

Loading