[PRODCRE-1802, PRODCRE-1803] add evm and solana keys to corekeys#1815
Closed
[PRODCRE-1802, PRODCRE-1803] add evm and solana keys to corekeys#1815
Conversation
product-security-plaid-production
bot
requested review from
krehermann and
michelemin
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for EVM and Solana key generation and encryption/decryption functionality to the corekeys package, enabling compatibility with the core node's key import requirements.
Changes:
- Implements
GenerateEncryptedEVMKeyandFromEncryptedEVMKeyfunctions for EVM key handling - Implements
GenerateEncryptedSolanaKeyandFromEncryptedSolanaKeyfunctions for Solana key handling - Adds comprehensive test coverage for both EVM and Solana key operations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| keystore/corekeys/evm.go | Implements EVM key generation and decryption utilities using ECDSA_S256 key type |
| keystore/corekeys/evm_test.go | Tests EVM key round-trip encryption/decryption, wrong password handling, and invalid format scenarios |
| keystore/corekeys/solana.go | Implements Solana key generation and decryption utilities using Ed25519 key type |
| keystore/corekeys/solana_test.go | Tests Solana key round-trip encryption/decryption, wrong password handling, and invalid format scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
Contributor
Author
|
moved to #1817 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.