Allow rateLimitAdmin to tune limiters via SetConfig; restrict SetRateLimitConfig to poolOwner#612
Open
stackman27 wants to merge 10 commits into
Open
Allow rateLimitAdmin to tune limiters via SetConfig; restrict SetRateLimitConfig to poolOwner#612stackman27 wants to merge 10 commits into
stackman27 wants to merge 10 commits into
Conversation
|
👋 stackman27, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
stackman27
force-pushed
the
sish/fcr-changes
branch
2 times, most recently
from
25d70fc to
45760c8
Compare
friedemannf
requested changes
Jun 2, 2026
Comment on lines
+514
to
+520
| when (caller /= poolOwner) $ do | ||
| assertMsg "SetRateLimitConfig: rateLimitAdmin cannot change inboundRateLimiter" | ||
| (arg.inboundRateLimiter == cfg.inboundRateLimiter) | ||
| assertMsg "SetRateLimitConfig: rateLimitAdmin cannot change inboundCustomBlockConfirmationsRateLimiter" | ||
| (arg.inboundCustomBlockConfirmationsRateLimiter == cfg.inboundCustomBlockConfirmationsRateLimiter) | ||
| assertMsg "SetRateLimitConfig: rateLimitAdmin cannot change outboundRateLimiter" | ||
| (arg.outboundRateLimiter == cfg.outboundRateLimiter) |
Member
There was a problem hiding this comment.
With these assertions, what can the rateLimitAdmin even do?
From the looks of it, this will now always fail if any of the rate limiters are to be changed, which is the whole point of this choice
Member
There was a problem hiding this comment.
If we wanted to do this, I think we should allow the RL admin to call SetConfig on the rate limiters themselves
stackman27
changed the title
stackman27
force-pushed
the
sish/fcr-changes
branch
from
25bb2ff to
69f7b18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow rateLimitAdmin to tune limiters via SetConfig; restrict SetRateLimitConfig to poolOwner