Skip to content

relayer: defer getClient calls#338

Merged
jmank88 merged 1 commit intodevelopfrom
relayer-get-client
Feb 16, 2026
Merged

relayer: defer getClient calls#338
jmank88 merged 1 commit intodevelopfrom
relayer-get-client

Conversation

@jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Feb 13, 2026

It is critical that construction does not depend on external resources being online. This PR defers some client fetches that were being done in constructors, because the implementations block on getting chain IDs from the RPCs.

@jmank88 jmank88 requested a review from a team as a code owner February 13, 2026 15:11
@github-actions
Copy link
Contributor

👋 jmank88, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@jmank88
Copy link
Collaborator Author

jmank88 commented Feb 13, 2026

@amit-momin This is the sort of problem that I was looking for with our other recent issue. Although this log message was quite obvious, with a fast failure rather than a timeout.

@jmank88 jmank88 merged commit 3b906fb into develop Feb 16, 2026
19 checks passed
@jmank88 jmank88 deleted the relayer-get-client branch February 16, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants