fix: (dependency review) new preset allow-listing certain deps#1413
Merged
fix: (dependency review) new preset allow-listing certain deps#1413
Conversation
erikburt
force-pushed
the
fix/dependency-review-allowed-deps
branch
from
32e92d0 to
a8d53e1
Compare
erikburt
force-pushed
the
fix/dependency-review-allowed-deps
branch
from
a8d53e1 to
8ff6201
Compare
erikburt
changed the title
erikburt
changed the title
chainchad
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add new preset, allowing two deps that we are incorrectly flagging for license violations.
license-deny-vulnerability-high-custompreset.DEPENDENCY_REVIEW_CONFIG_PRESETrepository variable (https://docs.github.com/en/rest/actions/variables?apiVersion=2022-11-28#create-a-repository-variable)Testing
https://github.com/smartcontractkit/releng-test/actions/runs/21881895055
Caveats
The option doesn't support specific dependencies and licenses, so we basically have to ignore these packages regardless of their license. This would be a problem if they changed to something else that we cannot use for example.
DX-2809