Fix include paths for compatibility#1079
Open
bpm-mcgill wants to merge 1 commit intosmartcmd:mainfrom
Open
Conversation
MSVC allows backslashes and case-insensitive include paths, which causes build failures on other compilers. This commit: - Converts all include backslashes to forward slashes. - Fixes capitalization mismatches to match the actual filesystem.
|
This MR drastically cuts down porting and compiling on MAC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MSVC allows backslashes and case-insensitive include paths, which causes build failures on other compilers. This commit:
Changes
Every .c, .cpp, .h, .hpp file was reviewed and every single include backslash was switched to a forward slash. Some of the includes also had capitalization mismatches, so those were fixed as well.
Behavior
Behavior did NOT change at all. The code still compiles the exact same. None of these changes actually affect how the code compiles or the final binary. Just to be sure, I have personally verified that the codebase still compiles and runs.
Fix Implementation
An specific tailored automated script was made in order to automatically apply these changes to the codebase. The script can be provided if needed.
AI Use Disclosure
N/A
Related Issues
It seems 465 is having issues getting the changes merged. This PR just breaks off an aspect of 465 and separates it.
These changes set up eventually having Linux cross-compile support.