Use default_factory for OrderResponse order_id and created_at - #1
Open
Wired4ncer wants to merge 1 commit into
Open
Use default_factory for OrderResponse order_id and created_at#1Wired4ncer wants to merge 1 commit into
Wired4ncer wants to merge 1 commit into
Conversation
Field(default=str(uuid.uuid4())) and Field(default=datetime.now(timezone.utc)) are evaluated once at class-definition time, so every OrderResponse built without an explicit value shared a single frozen order_id and a single frozen created_at timestamp. Switch both to default_factory so they are produced per instance. Adds tests/test_order_response_defaults.py (no node/relay required). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading through publsp closely (considering helping revive it), I noticed
OrderResponse.order_idandOrderResponse.created_atuse plain default values rather than default factories:Because these are evaluated once, at class-definition (import) time, every
OrderResponseconstructed without explicit values shares the sameorder_idand the samecreated_atfor the lifetime of the process. Two orders created in one run would collide onorder_idand report an import-time timestamp instead of their real creation time.Fix
Switch both to
default_factoryso each instance gets a fresh value:Tests
Adds
tests/test_order_response_defaults.py— asserts twoOrderResponseinstances get distinctorder_ids and monotonic/independentcreated_ats. Node-free (no LND connection needed), so it runs in CI as-is.All up for discussion — happy to adjust naming or style to match your conventions.
🤖 Generated with Claude Code