Skip to content

feat(step-issuer): add extraInitContainers and extraContainers support - #265

Merged
joshdrake merged 1 commit into
smallstep:masterfrom
vishalud:feat/extra-containers-step-issuer
Jun 29, 2026
Merged

feat(step-issuer): add extraInitContainers and extraContainers support#265
joshdrake merged 1 commit into
smallstep:masterfrom
vishalud:feat/extra-containers-step-issuer

Conversation

@vishalud

Copy link
Copy Markdown
Contributor

Description

Add extraInitContainers and extraContainers to the step-issuer chart values, allowing users to inject sidecar and init containers into the controller Deployment.

This is a natural companion to the passwordFile/passwordEnv feature added in step-issuer v0.11.0 (PR #365). Users who manage secrets with tools like HashiCorp Vault Agent need a way to inject the agent container that renders the password file into the pod. Without this, the only options are a kustomize post-render patch or the Vault Agent Injector webhook (which not all platforms run).

Usage example

extraInitContainers:
  - name: vault-agent-init
    image: vault:1.15
    env:
      - name: VAULT_ADDR
        value: https://vault.example.com
    volumeMounts:
      - name: vault-home
        mountPath: /home/vault

volumes:
  - name: vault-home
    emptyDir:
      medium: Memory

volumeMounts:
  - name: vault-home
    mountPath: /home/vault

Then in the StepIssuer CR:

provisioner:
  passwordFile: /home/vault/secrets/provisioner-password

Changes

  • values.yaml: Added extraInitContainers: [] and extraContainers: []
  • templates/deployment.yaml: Render both in the pod spec when provided

Tested with helm template — renders correctly with and without values set.

Allow injecting init containers and sidecar containers into the
step-issuer Deployment via Helm values. This is needed for secret
agent sidecars (e.g. HashiCorp Vault Agent) that render passwords
for the new passwordFile/passwordEnv feature added in v0.11.0.

Without this, users who do not run the Vault Agent Injector webhook
have no clean way to populate the password file that step-issuer
reads via passwordFile in the StepIssuer CR.
@vishalud
vishalud requested a review from a team as a code owner June 29, 2026 09:50
@CLAassistant

CLAassistant commented Jun 29, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the needs triage Waiting for discussion / prioritization by team label Jun 29, 2026
@joshdrake
joshdrake merged commit f6360f3 into smallstep:master Jun 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants