feat(step-issuer): add extraInitContainers and extraContainers support - #265
Merged
joshdrake merged 1 commit intoJun 29, 2026
Merged
Conversation
Allow injecting init containers and sidecar containers into the step-issuer Deployment via Helm values. This is needed for secret agent sidecars (e.g. HashiCorp Vault Agent) that render passwords for the new passwordFile/passwordEnv feature added in v0.11.0. Without this, users who do not run the Vault Agent Injector webhook have no clean way to populate the password file that step-issuer reads via passwordFile in the StepIssuer CR.
joshdrake
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
extraInitContainersandextraContainersto the step-issuer chart values, allowing users to inject sidecar and init containers into the controller Deployment.This is a natural companion to the
passwordFile/passwordEnvfeature added in step-issuer v0.11.0 (PR #365). Users who manage secrets with tools like HashiCorp Vault Agent need a way to inject the agent container that renders the password file into the pod. Without this, the only options are a kustomize post-render patch or the Vault Agent Injector webhook (which not all platforms run).Usage example
Then in the StepIssuer CR:
Changes
values.yaml: AddedextraInitContainers: []andextraContainers: []templates/deployment.yaml: Render both in the pod spec when providedTested with
helm template— renders correctly with and without values set.