Skip to content

Fix Broken Tooltips #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slprime merged 1 commit into from
Jun 28, 2026
Merged

Fix Broken Tooltips #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 33 additions & 29 deletions ...va/com/slprime/chromatictooltipscompat/mixins/late/notenoughitems/TooltipFilterMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,46 +29,50 @@ public class TooltipFilterMixin {
*/
@Overwrite(remap = false)
private static String getTooltip(ItemStack itemstack) {
final TooltipTarget target = TooltipRegistry.sanitizeTarget(TooltipTarget.ofItem(itemstack));
final StringBuilder tooltip = new StringBuilder(128);

if (target.isItem()) {
for (Object info : ItemInfoEnricher.getItemInformation(target)) {
if (info instanceof String str) {
final ITooltipComponent component = TooltipHandler.getTooltipComponent(str);
if (component instanceof DyncamicTextComponent dynamic) {
final String text = dynamic.getHandler()
.get();
if (text != null) {
tooltip.append(text)
try {
final TooltipTarget target = TooltipRegistry.sanitizeTarget(TooltipTarget.ofItem(itemstack));

if (target.isItem()) {
for (Object info : ItemInfoEnricher.getItemInformation(target)) {
if (info instanceof String str) {
final ITooltipComponent component = TooltipHandler.getTooltipComponent(str);
if (component instanceof DyncamicTextComponent dynamic) {
final String text = dynamic.getHandler()
.get();
if (text != null) {
tooltip.append(text)
.append("\n");
}
} else {
tooltip.append(str)
.append("\n");
}
} else {
tooltip.append(str)
.append("\n");
}
}
}

for (EnchantmentData enchantmentData : EnchantmentEnricher.getEnchantments(target)) {
tooltip.append(enchantmentData.enchantment.getTranslatedName(enchantmentData.level))
.append("\n");
tooltip.append(enchantmentData.hint)
.append("\n");
}
for (EnchantmentData enchantmentData : EnchantmentEnricher.getEnchantments(target)) {
tooltip.append(enchantmentData.enchantment.getTranslatedName(enchantmentData.level))
.append("\n");
tooltip.append(enchantmentData.hint)
.append("\n");
}

for (ItemStats itemStats : ItemStatsEnricher.getAttributeModifiers(target)) {
tooltip.append(itemStats.getTextLine())
.append("\n");
}
} else if (target.isFluid()) {
for (Object info : FluidInfoEnricher.getFluidInformation(target)) {
if (info instanceof String str) {
tooltip.append(str)
for (ItemStats itemStats : ItemStatsEnricher.getAttributeModifiers(target)) {
tooltip.append(itemStats.getTextLine())
.append("\n");
}
} else if (target.isFluid()) {
for (Object info : FluidInfoEnricher.getFluidInformation(target)) {
if (info instanceof String str) {
tooltip.append(str)
.append("\n");
}
}
}
}

} catch (Throwable ignored) {}

return EnumChatFormatting.getTextWithoutFormattingCodes(tooltip.toString());
}
Expand Down
Loading