Skip to content

Restore f3h item string #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slprime merged 4 commits into from
May 26, 2026
Merged

Restore f3h item string #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36db686
Restore F3+H item string id functionality
C0bra5 May 21, 2026
51635d1
revert to pre-chromatic tooltips functionality
C0bra5 May 26, 2026
0d93390
make return conditional on addition
C0bra5 May 26, 2026
222130e
use is empty.
C0bra5 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/main/java/com/slprime/chromatictooltips/enricher/ModInfoEnricher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ public EnumSet<TooltipModifier> mode() {
@Override
public TooltipLines build(TooltipContext context) {

if (!EnricherConfig.modInfoEnabled) {
return null;
}

final TooltipLines components = new TooltipLines();
final TooltipTarget target = context.getTarget();
UniqueIdentifier identifier = UNKNOWN_IDENTIFIER;

Expand All @@ -71,13 +66,18 @@ public TooltipLines build(TooltipContext context) {
identifier.name);
TooltipUtils.postEvent(event);

if (TooltipUtils.isCtrlKeyDown() && TooltipUtils.mc().gameSettings.advancedItemTooltips) {
final TooltipLines components = new TooltipLines();
// always add the item string id when adv tooltips is enabled
if (TooltipUtils.mc().gameSettings.advancedItemTooltips) {
components.line(TooltipUtils.translate("enricher.modinfo.identifier", event.modId, event.itemId));
} else {
}

// only add mod name if the enricher is enabled.
if (EnricherConfig.modInfoEnabled) {
components.line(TooltipUtils.translate("enricher.modinfo.modname", event.modName));
}

return components;
return components.isEmpty() ? null : components;
}

protected static UniqueIdentifier getIdentifier(ItemStack stack) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/assets/chromatictooltips/lang/en_US.lang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ chromatictooltips.enricher.stacksize.container.short=§8Container Amount: §7%s
chromatictooltips.enricher.stacksize.container.full=§8Container Amount: §7%s = %s * %s + %s

chromatictooltips.enricher.modinfo.modname=§9§o%s
chromatictooltips.enricher.modinfo.identifier=§9§o%s:§8%s
chromatictooltips.enricher.modinfo.identifier=§8%s:%s

chromatictooltips.enricher.hotkeys.keybind.entry=§6%s§7 - §7%s
chromatictooltips.enricher.hotkeys.keybind.keys=§8 / §6
Expand Down