Skip to content

Refresh Mneme branding: README hero and plugin-list icon - #675

Merged
modusensus merged 2 commits into
mainfrom
docs/readme-banner
Nov 12, 2026
Merged

modusensus merged 2 commits into
mainfrom
docs/readme-banner

Conversation

@modusensus

@modusensus modusensus commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

What

  • README hero — the root, dsh-mneme/ and mcp/ READMEs now open with images/mneme-banner-hero.webp (1672×941, 282 KiB). The 2.1 MiB source PNG would have doubled the images/ directory. The root README uses a relative path; the two sub-READMEs use the raw absolute URL because npm does not resolve relative image paths (../images/... breaks on npmjs.com).
  • Plugin-list icon — package.json's icon now points at assets/icon.png (256×256 RGBA, rounded corners genuinely transparent, 120,715 B — under the host's 256 KiB cap). The retired assets/icon.svg is removed; docs/DIRECTORIES.md and CHANGELOG.md follow.

Tests

  • The icon case in test/client.test.js no longer compares the SVG against the inlined MNEME_MARK_D (the list icon and the sidebar mark are intentionally different marks now). It validates the PNG itself: magic bytes, 256×256 IHDR, 8-bit, colour type 6 (RGBA) — the host falls back to a generic glyph on a bad file without reporting an error.
  • Mutation-checked: 512×512 → red, RGB without alpha → red, restored → green.
  • Full suite: 3446 tests, 3445 pass, 0 fail, 1 skipped.

Summary by CodeRabbit

  • 品牌与图标
    • 更新 README 中的 Mneme 横幅图片,并调整替代文本。
    • 插件图标改用 256×256 PNG 图片。
  • 文档
    • 补充横幅和图标资源相关说明及变更记录。

Copilot AI lite review requested due to automatic review settings November 12, 2026 16:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

仓库 README 的横幅图片已更新,两个子目录 README 新增横幅。插件图标路径改为 PNG,资源说明和客户端测试也相应更新。

Changes: 品牌资源更新

Layer / File(s) Summary
更新 README 横幅
README.md, dsh-mneme/README.md, mcp/README.md, dsh-mneme/CHANGELOG.md
根目录 README 改用新的 WebP 横幅。两个子目录 README 新增居中横幅。变更记录说明横幅路径调整。
切换插件图标为 PNG
dsh-mneme/package.json, dsh-mneme/docs/DIRECTORIES.md, dsh-mneme/test/client.test.js
包元数据和资源说明将图标路径改为 assets/icon.png。客户端测试检查 PNG 签名、256×256 尺寸、8 位位深和 RGBA 通道,并保留文件存在及大小限制。

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: heptaspirit

Merge Risk: Minimal · up to 1b1e2

This change refreshes branding images and switches the plugin icon to PNG. No functional risk is evident and it is ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed 标题“Refresh Mneme branding: README hero and plugin-list icon”准确概括了主要变更:README 顶部横幅图替换,以及插件列表图标从 SVG 改为 PNG。变更集中的 README、package.json、测试、CHANGELOG 和图标文件都与标题描述的两项品牌更新相符。标题简洁,未包含文件清单或模糊用语。
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 857f294 and 1b1e22c.

Files ignored due to path filters: 3

  • dsh-mneme/assets/icon.png is excluded by !**/*.png
  • dsh-mneme/assets/icon.svg is excluded by !**/*.svg
  • images/mneme-banner-hero.webp is excluded by !images/**
Files selected for processing: 7

  • README.md
  • dsh-mneme/CHANGELOG.md
  • dsh-mneme/README.md
  • dsh-mneme/docs/DIRECTORIES.md
  • dsh-mneme/package.json
  • dsh-mneme/test/client.test.js
  • mcp/README.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@modusensus
modusensus merged commit 11ac14d into main Nov 12, 2026
13 checks passed
@modusensus
modusensus deleted the docs/readme-banner branch November 12, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants