Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/guided-review/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Each review gets its own Paseo workspace, checked out at the change, with a **Gu

Requires:

- Paseo 0.13 or newer
- Paseo 0.15 or newer
- `pnpm` on the daemon's `PATH`
- Either or both:
- [`gh`](https://cli.github.com/), logged in with `gh auth login`, to review pull requests on github.com; GitHub Enterprise is not supported
Expand Down
4 changes: 2 additions & 2 deletions plugins/guided-review/index.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,14 @@ export default function contribute(server: PluginServerContext) {

// The guide agent is read-only. Its provider's plan or read-only mode is the first guard and this
// the second, since not every provider has such a mode; the generation job answers what it misses.
server.on("agent.permission_requested", async ({ agent, request }, context) => {
server.addHook("agent.permission.before", async ({ agent, request }, context) => {
connected(context);
await guideAgents
.onPermissionRequested(agent.id, request)
.catch((error: unknown) => log(`Answering a permission request of ${agent.id} failed: ${String(error)}`));
});
// Paseo archives a workspace's agents with it; this makes sure of the guide agents, whose guide ends there.
server.on("workspace.archived", async ({ workspace }, context) => {
server.addHook("workspace.archive.after", async ({ workspace }, context) => {
connected(context);
await service
.workspaceArchived({ workspaceId: workspace.id })
Expand Down
4 changes: 2 additions & 2 deletions plugins/guided-review/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"test": "node --test \"{client,server,shared}/**/*.test.ts\""
},
"devDependencies": {
"@getpaseo/client": "0.13.0",
"@getpaseo/plugin": "0.13.0",
"@getpaseo/client": "0.15.0",
"@getpaseo/plugin": "0.15.0",
"@tanstack/react-query": "^5.90.11",
"@types/markdown-it": "^14.2.0",
"@types/node": "^26.2.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/guided-review/paseo-plugin.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "guided-review",
"description": "A trunk-first guide to a pull request, with a draft review built alongside it.",
"requirements": { "paseo": ">=0.13.0" },
"requirements": { "paseo": ">=0.15.0" },
"build": [["pnpm", "install", "--frozen-lockfile"]]
}
2 changes: 1 addition & 1 deletion plugins/guided-review/server/guide-agent/paseo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export type PaseoGuideAgentsOptions = {

export type PaseoGuideAgents = GuideAgentPort & {
/**
* For the `agent.permission_requested` hook: denies a guide agent's request to change anything, and
* For the `agent.permission.before` hook: denies a guide agent's request to change anything, and
* leaves every other agent's requests alone. Guide agents are told apart by their label, which
* survives a plugin restart where an in-memory list would not.
*/
Expand Down
70 changes: 66 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ packages:
allowBuilds:
node-pty: true
minimumReleaseAgeExclude:
- '@getpaseo/client@0.7.0 || 0.8.0 || 0.9.1 || 0.11.0'
- '@getpaseo/protocol@0.7.0 || 0.8.0 || 0.9.1 || 0.11.0'
- '@getpaseo/relay@0.7.0 || 0.8.0 || 0.9.1 || 0.11.0'
- '@getpaseo/plugin@0.8.0 || 0.9.1 || 0.11.0'
- '@getpaseo/client@0.7.0 || 0.8.0 || 0.9.1 || 0.11.0 || 0.15.0'
- '@getpaseo/protocol@0.7.0 || 0.8.0 || 0.9.1 || 0.11.0 || 0.15.0'
- '@getpaseo/relay@0.7.0 || 0.8.0 || 0.9.1 || 0.11.0 || 0.15.0'
- '@getpaseo/plugin@0.8.0 || 0.9.1 || 0.11.0 || 0.15.0'
- '@getpaseo/highlight@0.11.0'
Loading