Va interfaces - #64
Open
bhardwaj-gopika wants to merge 15 commits into
Open
Conversation
Contributor
Author
bhardwaj-gopika
marked this pull request as draft
September 8, 2026 16:54
bhardwaj-gopika
marked this pull request as ready for review
September 8, 2026 22:42
roussel-ryan
reviewed
Sep 8, 2026
roussel-ryan
left a comment
roussel-ryan
left a comment
Collaborator
There was a problem hiding this comment.
Only had a chance to look at 1 file
| impact_cu_inj ('YAG02', 'YAG03') | ||
| bmad_cu_hxr ('CATHODE', 'YAG02', 'YAG03', 'OTRH1', 'OTRH2', 'OTR1', 'OTR2', 'OTR3', 'OTR4', 'OTR11', 'OTR12', 'OTR21', 'OTRDMP', 'END') | ||
| surrogate_cu_inj ('OTR2',) | ||
| cheetah_cu_hxr () |
Collaborator
There was a problem hiding this comment.
Needs to be populated
| >>> list_models(facility="facet2") | ||
| ['impact_f2e_inj', 'surrogate_f2e_inj', 'bmad_f2_elec'] | ||
|
|
||
| >>> list_models(engine="bmad") |
Collaborator
There was a problem hiding this comment.
Lets use the 'simulator' nomenclature here and elsewhere since that is what is used in lume
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for interface to use virtual accelerators for both LCLS and FACET.
Adds virtual_accelerator.registry — a single get_model() entry point replacing the per-model get_*_model builders, with a declarative table of what exists and how to configure it.
Seven models registered: LCLS (impact_cu_inj, bmad_cu_hxr, surrogate_cu_inj, cheetah_cu_hxr) and FACET-II (impact_f2e_inj, surrogate_f2e_inj, bmad_f2_elec).