Conversation
shawnhammer manages its own tmux session via `tmux kill-session` / `tmux new-session`. If the script is launched from inside that (or any) tmux session, the surrounding shell is torn down and the script silently dies with no obvious error. Guard against that up front by checking $TMUX and bailing with a clear message before any side effects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmux kill-session/tmux new-session. When the script is launched from inside that (or any) tmux session, the surrounding shell gets torn down and the script silently dies with no obvious error.$TMUXguard at the very top ofscratch/shawn/scripts/shawnhammer.shthat bails with a clear error before any side effects.Test plan
bash -n scratch/shawn/scripts/shawnhammer.sh— syntax OKTMUXset: printsERROR: shawnhammer cannot be run from inside a tmux session.and exits 1 (no tmux session is killed)TMUXunset: guard is skipped; script proceeds to the existing arg/cfg validation (no false positive)tmux new -s test78then runshawnhammer— confirm it refuses; detach and re-run from a normal shell — confirm normal startup is unchanged.Note on PR #967
PR #967 renames this file to
scripts/smurf_startup.sh. Whichever lands second is a trivial rebase to move the same 10-line guard into the renamed file.