Stabilize concavity-cropping unit test for Python 3.11 CI - #23
Draft
roussel-ryan with Copilot wants to merge 2 commits into
Draft
roussel-ryan with Copilot wants to merge 2 commits into
roussel-ryan with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Test Suite (3.11)
Stabilize concavity-cropping unit test for Python 3.11 CI
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Suite (3.11)was failing on a single concavity-cropping test due to hard-coded expectations tied to GP fit details at specific indices. The failure was test brittleness, not a production regression.Root cause
test_cropping_by_concavity_returns_masks_and_modelassumed fixed cropped indices (0,-2) from a GP-derived concavity mask.Change made
NaN,concavity_values <= 0),Why this is safer