Release Candidate 7.2.4#277
Merged
Merged
Conversation
include/GpuAsyncLib.h: Switch off of bitfields for AXI DMA header
Non-functional cleanup across the canonical sources in common/, include/,
docs/, Yocto/, and the per-driver READMEs (the data_dev/, rce_stream/, and
Yocto/recipes-*/files/ trees pick up the C/C++ fixes automatically via
their existing symlinks to common/ and include/).
Comments and Doxygen-adjacent text
- common/driver/axis_gen1.c: 'destc' -> 'dest' in the IRQ handler comment
- include/GpuAsyncRegs.h: 'defintiions' -> 'definitions'
argp_option help strings (user-visible --help output only)
- common/app/dmaRead.cpp: 'Comma seperated' -> 'Comma separated'
- common/app/dmaLoopTest.cpp: 'Comman seperated' -> 'Comma separated'
Documentation prose
- data_dev/driver/README.md: 'drviers' -> 'drivers' (x2);
tighten 'After you completed all the
"System Configuration" configuration steps'
to 'After completing all the
"System Configuration" steps'
- Yocto/README.md: 'does NOT require an entire for the
device-tree' -> '... an entry for ...'
- docs/reference/dma-legacy.rst: DMA 'transer' -> 'transfer'
No identifier, macro, function, struct, field, or logic changes.
Verified with 'make driver' and 'make app' on Linux 6.8.0-111-generic.
The Sphinx site at https://slaclab.github.io/aes-stream-drivers is the canonical documentation. The top-level README duplicated build, DKMS, Yocto, RCE, and CI content that already lives in docs/how-to/ and docs/explanation/, guaranteeing drift between the two. Keep only what the README is uniquely positioned to provide: - repo name + one-line description for GitHub repo card - prominent link to the full documentation site - DOE Code Record link 199 lines -> 7 lines.
When /etc/rc.local rebuilds drivers as root from a tree cloned by an unprivileged user, modern git (>=2.35.2, post-CVE-2022-24765) refuses the worktree with "fatal: detected dubious ownership in repository at '/u1/aes-stream-drivers'". The Makefile pipes git stderr to /dev/null, so the failure is silent: GITT falls through to "emulator"/"unknown" and /proc/datadev_0 reports the wrong "DMA Driver's Git Version". Wrap each git invocation with `-c safe.directory='*'` (git's documented escape hatch for trusted automated builds) and clear GIT_CONFIG_SYSTEM / GIT_CONFIG_GLOBAL so a hostile per-user core.fsmonitor / pager / credential helper cannot ride along into the read-only version queries. Touches the same ifndef-GITV block in data_dev, rce_hp_buffers, rce_memmap, rce_stream, and the Yocto axistreamdma recipe.
Replace the per-build `git describe` resolution in build-cpu.sh, build-gpu.sh and run_local_ci.sh with a literal GITV=emulator override so test artifacts are deterministic across runs and identifiable as a CI build regardless of branch / tag / dirty state. Phase 5 DKMS (release packaging via `make -C data_dev/driver dkms`) is intentionally unchanged so tagged release artifacts continue to embed the real git-derived version through the Makefile.
Fix typos and grammar; prune top-level README
Fix GITV detection when build runs as a different user than the clone owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description