doc: Document KV cache materialization during chunked prefill#114
Merged
Connor1996 merged 2 commits intoskyzh:mainfrom Apr 13, 2026
Merged
doc: Document KV cache materialization during chunked prefill#114Connor1996 merged 2 commits intoskyzh:mainfrom
Connor1996 merged 2 commits intoskyzh:mainfrom
Conversation
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Connor1996
changed the title
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This follow-up adds a short explanation for why chunked prefill materializes the KV cache with
mx.eval:src/tiny_llm_ref/batch.pybook/src/week2-06-prefill-and-batch.mdWhy
The existing code does the right thing, but the reason is easy to miss when reading the implementation or the chapter. This note makes it explicit that
mx.evalis there to keep the lazy graph from growing across prefill chunks.