Skip to content

Add support for comparing booleans #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mspiess wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for comparing booleans #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5faab6b
Remove superfluous `else`s after guard statements
mspiess Jan 4, 2026
8bd5b32
Add support for comparing booleans
mspiess Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/main/java/org/skyscreamer/jsonassert/JSONParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public class JSONParser {
// "A number can be represented as integer, real, or floating point. JSON does not support octal or hex
// ... [or] NaN or Infinity".
private static final String NUMBER_REGEX = "-?(?:0|[1-9]\\d*)(?:\\.\\d+)?(?:[eE][+-]?\\d+)?";
private static final String BOOLEAN_REGEX = "true|false";

private JSONParser() {}

Expand All @@ -41,10 +42,12 @@ public static Object parseJSON(final String s) {
if (s.trim().startsWith("{")) {
return new JSONObject(s);
}
else if (s.trim().startsWith("[")) {
if (s.trim().startsWith("[")) {
return new JSONArray(s);
} else if (s.trim().startsWith("\"")
|| s.trim().matches(NUMBER_REGEX)) {
}
if (s.trim().startsWith("\"")
|| s.trim().matches(NUMBER_REGEX)
|| s.trim().matches(BOOLEAN_REGEX)) {
return new JSONString() {
@Override
public String toJSONString() {
Expand Down
8 changes: 8 additions & 0 deletions src/test/java/org/skyscreamer/jsonassert/JSONAssertTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ public void testNumber() {
testFail("310.1e-1", "31.01", STRICT); // should fail though numbers are the same?
}

@Test
public void testBoolean() {
testPass("true", "true", STRICT);
testFail("true", "false", STRICT);
testPass("false", "false", STRICT);
testFail("false", "true", STRICT);
}

@Test
public void testSimple() {
testPass("{id:1}", "{id:1}", STRICT);
Expand Down