Fold the last note into v1.0.0 rather than the release after it - #249
Merged
Merged
Conversation
The heap finding landed after the batch that produced changes/v1.0.0.md, so its fragment sat in unreleased/ and the notes for the release it belongs to did not mention it. Batching again is not available once the other fragments are consumed, so the entry goes in by hand and the changelog is merged from the version files again. The date moves with it: these notes are dated the day the tag goes out, not the day they were first batched.
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The heap finding merged in #248 landed after
changie batchhad already consumed the other fragments, so its entry sat inchanges/unreleased/and the notes for the release it belongs to did not mention it. Tagging v1.0.0 in that state would have published release notes missing the correction.Type of Change
Changes
changes/v1.0.0.mdgains the heap entry under Documentation, by hand: re-batching is not available once the other fragments are gone.CHANGELOG.mdregenerated withchangie merge.Testing
make allpassesAlso run, as the pre-tag checks on the release page ask:
go test -run TestPublicAPISurface .,goreleaser check, and a check that the merged changelog has no version heading glued to a preceding bullet.Related Issues
Follows #248.