Repository navigation
feat(cfn): expand CloudFormation native provisioning and align Phase 1 documentation - #187
Merged
Merged
Conversation
…1 documentation - Add real provisioning and deletion logic in CloudFormation engine for AWS::Lambda::EventSourceMapping, AWS::Events::Rule, AWS::SSM::Parameter, and AWS::SecretsManager::Secret - Handle generic Name property in simulateResource fallback - Normalize Lambda function ARNs in EventSourceMapping to prevent duplicate ARN prefixes - Update docs/roadmap.md and docs/coverage.md with latest metrics and protocol coverage - Add unit and compatibility tests for expanded CFN provisioning - Add unreleased changelog entry
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses real-world IaC and CDK provisioning gaps identified during a critical review of Phase 1 goals, and resolves documentation/metric drift across the repository.
Key Improvements
CloudFormation Native Provisioning Expansion (
internal/services/cloudformation/engine.go):AWS::Lambda::EventSourceMapping(callslambda.CreateEventSourceMapping/lambda.DeleteEventSourceMapping)AWS::Events::Rule(callseventbridge.PutRule/eventbridge.DeleteRule)AWS::SSM::Parameter(callsssm.PutParameter/ssm.DeleteParameter)AWS::SecretsManager::Secret(callssecretsmanager.CreateSecret/secretsmanager.DeleteSecret)simulateResource) to extract genericprops["Name"]as physical resource ID when specific name properties are not provided.Lambda EventSourceMapping Function ARN Normalization (
internal/services/lambda/provider.go):functionARNhelper idempotent to prevent duplicate prefixes (e.g.,arn:aws:lambda:...:function:arn:...) when full ARNs are supplied as function names.extractFunctionNamehelper to robustly locate functions by short name or ARN in ESM mappings.Documentation & Metrics Alignment:
docs/roadmap.md: Updated unimplemented operation counts to reflect current state (477 all registered / 267 serving target).docs/coverage.md: Aligned wire protocol table and prose to includeec2Queryand native CBOR (rpcv2Cbor) support, and updated compatibility testing totals to 427 services.cmd/devcloud/coverage_test.goregex and coverage gating tests pass cleanly.Testing & Quality Assurance:
internal/services/cloudformation/engine_test.go(TestProvisionNewResourceTypes) covering creation, deletion, and physical ID propagation.test/compatibility/test_cloudformation.py:test_create_stack_provisions_ssm_events_secretstest_create_stack_provisions_lambda_esmchanges/unreleased/Added-20261009-213500.yaml.go test ./...) and compatibility test suite.