Skip to content

feat(aws): implement phase 1D generic CRUD semantic verb expansion - #184

Merged
skyoo2003 merged 1 commit into
mainfrom
feat/phase-1d-crud-semantic-verbs
Oct 9, 2026
Merged

skyoo2003 merged 1 commit into
mainfrom
feat/phase-1d-crud-semantic-verbs

Conversation

@skyoo2003

Copy link
Copy Markdown
Owner

Summary

Implements Phase 1D of the AWS roadmap: Generic CRUD Engine Semantic Verb Expansion across the fleet, promoting 2,014 operations into auto-crud and reducing the global unimplemented baseline from 2,511 to 497.

Key Changes

  1. Semantic Verb Classification:
    • Expanded verb prefix detection in internal/codegen/gen_crud_meta.go for:
      • Relate: Associate, Disassociate, Attach, Detach, Add, Remove, Connect, Disconnect, Authorize, Revoke, Transfer, Assign, Unassign, Link, Unlink.
      • Toggle: Enable, Disable, Start, Stop, Reboot, Reset, Cancel, Terminate, Pause, Unpause, Resume, Suspend, Unsuspend, Activate, Deactivate, Archive, Unarchive, Lock, Unlock, Accept, Reject, Confirm, Verify, Rotate, Abort, Retry, Sync, Resync, Deprecate.
      • Lifecycle & Mutation Aliases: Provision, Deprovision, Promote, Demote, Allocate, Release, Purchase, Restore, Apply, Replace, Modify, Configure, Clone, Copy, Set.
      • Batch Variants: BatchAssociate, BatchDisassociate, BatchAttach, BatchDetach, BatchCreate, BatchDelete, BatchEnable, BatchDisable, BatchGet, BatchPut, BatchUpdate, BatchWrite, BatchReboot, BatchResume, BatchReset, BatchStart, BatchSuspend, BatchApply, BatchProvision, BatchDeprovision.
      • Non-CRUD data plane prefixes (Import, Export, Upload, Download, Send, Post, Test, Evaluate, Validate, Inspect, Check, Poll) remain deliberately unclassified (Verb: "") so they decline with honest AWS errors rather than fabricating success.
  2. Stateful Generic CRUD Engine Execution:
    • Implemented Relate and Toggle execution in internal/shared/crud/crud.go.
    • Relate stamps association state into document representations and returns 200 OK.
    • Toggle statefully updates Status=ACTIVE, State=ENABLED, Return=true or equivalent flags in-memory and returns operation status envelopes.
  3. Route Specificity & Shadowing Prevention:
    • Updated internal/shared/httproute/match.go to test non-greedy patterns before greedy {Label+} patterns. This prevents broad greedy patterns (such as DeletePortal "/portals/{portalArn+}") from shadowing more specific sub-resource patterns (such as ExpireSession "/portals/{portalId}/sessions/{sessionId}").
  4. Metrics Impact:
    • Serving target auto-crud: 6,380 → 7,534 (+1,154 operations)
    • Serving target unimplemented: 1,426 → 272 (-1,154 operations)
    • All registered auto-crud: 12,058 → 14,072 (+2,014 operations)
    • All registered unimplemented: 2,511 → 497 (-2,014 operations)
    • Serving ≥1 operation: 426 → 427
    • Registered-only: 5 → 4

Verification

  • go test ./... passed cleanly (100%).
  • go build ./... and go vet ./... passed cleanly.
  • pytest test/compatibility/test_crud_engine.py passed (2/2).
  • pytest test/compatibility/test_service_smoke.py passed (430/430).
  • pytest test/compatibility/test_no_fabricated_success.py passed (186/186 passed, 2 skipped, 0 failed).

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests Test code and test infrastructure codegen Smithy codegen and generated code services AWS service implementations labels Oct 8, 2026
@skyoo2003
skyoo2003 force-pushed the feat/phase-1d-crud-semantic-verbs branch 2 times, most recently from f1bd48f to 4d6fa72 Compare October 9, 2026 06:11
@skyoo2003
skyoo2003 force-pushed the feat/phase-1d-crud-semantic-verbs branch from 4d6fa72 to a028d8e Compare October 9, 2026 06:23
@github-actions github-actions Bot removed the services AWS service implementations label Oct 9, 2026
@skyoo2003
skyoo2003 merged commit 624e8a2 into main Oct 9, 2026
11 checks passed
@skyoo2003
skyoo2003 deleted the feat/phase-1d-crud-semantic-verbs branch October 9, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codegen Smithy codegen and generated code documentation Improvements or additions to documentation tests Test code and test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant