Repository navigation
feat(aws): implement phase 1C compute and network operations - #183
Merged
Merged
Conversation
skyoo2003
force-pushed
the
feat/phase-1c-ec2-integrations
branch
from
October 9, 2026 05:51
a05e035 to
27c8fb5
Compare
skyoo2003
force-pushed
the
feat/phase-1c-ec2-integrations
branch
from
October 9, 2026 06:11
27c8fb5 to
e1f0bae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Phase 1C: Compute & Network Integrations as outlined in the AWS Phase 1 full implementation plan.
Key Changes
Smithy Parser Protocol Detection (
internal/codegen/parser.go):aws.protocols#ec2Query, properly detecting and classifying the protocol as"ec2-query"instead of"".Codegen CRUD Admission (
internal/codegen/gen_crud_meta.go):"ec2-query"inengineServablealongsidequery,rest-xml,rest-json, andjson-*.CRUD Engine EC2 Protocol Support (
internal/shared/crud/crud.go,xml.go):protocolEC2Query = "ec2-query".Servable,NeedsBody,xmlProtocol, andHandleto parse URL/body form Action parameters and serialize to XML withtext/xmlContent-Type.encodeXMLto generate the native EC2 XML envelope (<OperationResponse xmlns="http://ec2.amazonaws.com/doc/2016-11-15/"><requestId>...</requestId>) with<item>list element wrappers (per EC2 Query specification).<Response><Errors><Error><Code>...</Code><Message>...</Message></Error></Errors><RequestID>...</RequestID></Response>).Gateway Router Integration (
internal/gateway/router.go):extractOperationNameto supportec2-queryAction parameter extraction without consuming request body.awsEC2QueryErrorenvelope andtext/xmlContent-Type forec2-querygateway error responses.EC2 Provider Wiring (
internal/services/ec2/provider.go):HandleRequestfrom hardcodedNotImplementedXML error toreturn nil, plugin.ErrUnhandledOp.wiresCRUDEngineto detect wiring and enables seamless gateway fallback to the generic CRUD engine.Manifest Regeneration & Coverage Impact:
manifest_gen.go,registry_gen.go, andservices.json.unimplementedoperations dropped from 691 to 193 (498 operations promoted toauto-crud).docs/coverage.mdand roadmap indocs/roadmap.md.Verification
go test ./internal/codegen/...: PASSgo test ./internal/shared/crud/...: PASSgo test ./internal/gateway/...: PASSgo test ./internal/services/ec2/...: PASSgo test ./cmd/devcloud/...: PASS (including published figure verification)go test ./internal/...: PASS (all 431 services pass)