fix: unbreak the v1.2.0 release notes and tighten the fragment ceiling to 200 - #168
Merged
Merged
Conversation
Six fragments wrote `Issue:` at the top level instead of under `custom:`, where `.changie.yaml` declares it. `changie batch` rendered them as `[#<no value>](.../issues/<no value>)`, which release.yml:234 rejects — the tag would have failed at the notes-validation step, after the guardrails had already passed. The pre-flight grep in RELEASE.md (`grep -L 'Issue: "[0-9]'`) matches both spellings, so it did not catch this. Also trims the #163 fragment from 484 to 337 characters, under the 400-char ceiling `.changie.yaml` sets and `changie new` enforces on fragments it writes itself. The CI-runner timing detail it dropped is in the issue.
… no model The protocol table said 12 services have no in-tree Smithy model and exactly one speaks a protocol the parser cannot read. Counted against internal/generated/fidelity/manifest_gen.go, it is 11 and two: `ec2` is model-backed but speaks `aws.protocols#ec2Query`, which parser.go:441-453 does not recognise alongside the five it does. That put the page at odds with fidelity-manifest.md:106 and compatibility-policy.md:78, which both say 11, and left a core service's missing engine coverage unexplained. Rows now sum to 431 either way, so the arithmetic did not expose it, and no test gates this table. Adds a paragraph separating what EC2 loses from what a registered-only service loses: EC2 is served by a hand-written provider and is not in the registered-only five, but its model-declared tail stays `unimplemented` rather than falling back to `auto-crud`.
…e fragments The 400-character ceiling was wide enough to hold two full sentences plus a subordinate clause, so it never pushed against the one-sentence rule it was meant to back — the #163 fragment reached 484 and still read as being in the spirit of the limit. At 200 the ceiling and the rule push the same way. Refits the eight unreleased fragments that were over. What came out is detail the linked issue already carries: the eight service names in #161, the CI-runner timing in #163, the DynamoDB and Lambda operation counts in #167. Also trims RELEASE.md's "right length" example, which was 203 characters and would have failed the limit the paragraph above it states, and labels both examples with their length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears what stood between
mainand av1.2.0tag — six changelog fragments whose issue links render empty, which the release workflow rejects — then halves the fragment body ceiling to 200 characters and refits every unreleased fragment to it. Also corrects a protocol table indocs/coverage.mdthat miscounts EC2.Related Issue
Refs #160, #161, #162, #163 — this corrects fragments and documentation those PRs added while still unreleased. No separate issue filed.
Changes
Release blocker — empty issue links
Issue:at the top level instead of undercustom:, where.changie.yamldeclares it.changie batch v1.2.0rendered them as[#<no value>](.../issues/<no value>), andrelease.yml:234rejects any entry not ending inissues/<positive int>)). The tag would have failed at notes validation, after the Go suite, the boto3 suite and the codegen drift check had all passed.grep -L 'Issue: "[0-9]'matches both the broken and the correct spelling, so the checklist passed on a tree that could not be tagged.Fragment ceiling 400 → 200
#163fragment reached 484 and still read as being within the spirit of the limit. At 200 the ceiling and the rule push the same way.docs/coverage.mdprotocol tableno in-tree model12 → 11,unrecognised protocol1 → 2. Counted againstinternal/generated/fidelity/manifest_gen.go: 11 entries carryModelBacked: false, and 13 carryProtocol: ""— the two-service difference isec2(aws.protocols#ec2Query, persmithy-models/ec2.json) andpartnercentralrevenuemeasurement(rpcv2Cbor).internal/codegen/parser.go:441-453recognises neither.unimplementedinstead ofauto-crud) from what a registered-only service loses (EC2 is served by a hand-written provider and is not in the registered-only five).Test Plan
changie batch v1.2.0 --dry-run | grep -c '<no value>'→ 0 (was 6); all nine entries render a live issue linkCGO_ENABLED=0 go test ./cmd/devcloud/→ okhugo --gc --minify && ./scripts/check-site-links.py→ 904 internal links across 24 pages all resolveFull pre-flight on this tree, for the record: codegen drift zero (regenerated to a temp dir and
diff -rqagainstinternal/generated),go test ./...green,make test-compat1,527 passed / 2 skipped / 1 xfailed.Checklist
golangci-lint run) — pre-commit hooks passed on all three commitsFollow-up
docs/coverage.mdstates "Every figure on this page is asserted against the binary bygo test ./cmd/devcloud/", but the protocol table is not among them —coverage_test.gocontains no reference to it. That is how these two rows drifted. Gating the table's protocol distribution against the manifest is worth a separate PR.