perf: optimize V3 search and staging - #259
Merged
Merged
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize V3 search hot paths and reduce Redis staging round trips. MemoryEfficient ASCII searches use a direct root index, FindBatch calls the serving engine directly, and V3 chunk/manifest staging is pipelined.
Type of Change
Checklist
Additional Notes
Valkey 8.1.10 Docker benchmark on 10k keywords showed MemoryEfficient ASCII engine median improvements of 21.9% for Find and 27.1% for FindIndex; V3 shared-text p95 improved 17.9% for Find and 22.7% for FindBatch. Multibyte paths were unchanged within benchmark variance.
Benchmark setup: valkey/valkey:8-alpine, localhost port mapping, Go 1.27.1, 3 repeated runs. Full repository verification passed: make all.