feat: add opt-in V3 delta search refresh - #255
Merged
Merged
Conversation
skyoo2003
marked this pull request as ready for review
September 13, 2026 13:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Updating one keyword in a large V3 dictionary currently rebuilds the entire search automaton before
WaitForVersioncompletes. This adds an opt-inMemoryEfficientpath that downloads changed buckets, publishes a base automaton with a small additions automaton and deletion set, and compacts it after one idle second. Changes above 128 keywords and other presets retain the full rebuild path. The Redis schema and V1/V2 behavior are unchanged.The option remains disabled by default because the release gate has not been measured: median commit-to-visibility latency for one add and one removal must each improve by at least 50% across Redis and Valkey and three million-keyword distributions, while search p95 and peak RSS each worsen by no more than 20%. The opt-in scale test now records commit-to-visibility timing and repeated single-keyword updates.
Type of Change
Checklist
make test)make vetmake lint)make build)changie new) if this change belongs in the changelog — one sentence (two at the very most), on a single line, 400 characters max; skip for internal-only changes (CI, tests, refactors); see RELEASE.mdAdditional Notes
make allpassed, including API audit, documentation verification, and license check.go test -race ./pkg/acor -run TestVersionedOverlayLifecycle -count=1passed. Million-keyword Redis/Valkey performance validation remains outstanding; the new path is opt-in until that gate passes.By submitting this PR, I agree that my contributions will be licensed under the Apache License 2.0.