feat: load global GUI plugins without decompiler, add first IMainWindow method - #2960
mostafaNazari702 wants to merge 3 commits into
Conversation
|
Things i noticed while working on this (not changed in this PR)
Should any of these become separate issues? I can open them. |
|
@skylot I would be thankful if you review this PR ASAP. I have also some other ideas of my own that depend on this PR. Thanks and good luck while reviewing! |
|
@skylot Any progress with this? or have you looked at anything yet? |
I checked this PR, but decided to try another approach to understand if better solution is possible. |
I might be able to help you if you maybe share some details regarding the "another approach". |
|
I commit my approach to master, in short: @mostafaNazari702 we still need to fix all issues mentioned by you in #2960 (comment), because this commit only apply code refactoring, so work on global plugins feature continues 🙂 |
Understood.
Will get started soon. |
❗ Please review the guidelines for contributing
Description
Quick follow-up to #2945 / #2913, i finished the two TODOs:
IMainWindow.open(files)so global plugins can open APKs without relying on GUI internals.Also added/updated tests for the plugin manager, global plugin lifecycle, and the new API.
A couple things i would like feedback on:
opena good firstIMainWindowAPI? What should come next?JadxPluginContext?