fix: compare field initializer values across constructors - #2956
Open
oriori1703 wants to merge 1 commit into
Open
oriori1703 wants to merge 1 commit into
oriori1703 wants to merge 1 commit into
Conversation
oriori1703
marked this pull request as draft
September 15, 2026 09:11
oriori1703
marked this pull request as ready for review
September 15, 2026 09:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JADX can incorrectly replace different constructor assignments with one shared field initializer, changing the behavior of the decompiled code. In this example, the second constructor should set
valueto2, but the broken output gives both constructors1.Broken output
Fixed output
Testing
Field-initialization tests, Checkstyle, and Spotless pass. The full
clean build distwas not run.